Skip to content

Commit 2bbe0fe

Browse files
authored
fix: remove confusing close label for navigation menu (#7463)
* fix: remove confusing close label for navigation menu * use `toggle` Signed-off-by: Antoine du Hamel <[email protected]> --------- Signed-off-by: Antoine du Hamel <[email protected]>
1 parent a6c0ad9 commit 2bbe0fe

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

apps/site/components/Containers/NavBar/index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ const NavBar: FC<NavbarProps> = ({
7070
id="sidebarItemToggler"
7171
type="checkbox"
7272
onChange={e => setIsMenuOpen(() => e.target.checked)}
73-
aria-label={t(
74-
`components.containers.navBar.controls.${isMenuOpen ? 'close' : 'open'}`
75-
)}
73+
aria-label={t(`components.containers.navBar.controls.toggle`)}
7674
/>
7775

7876
<div className={`${style.main} peer-checked:flex`}>

packages/i18n/locales/en.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
},
1313
"navBar": {
1414
"controls": {
15-
"open": "Show navigation menu",
16-
"close": "Close navigation menu"
15+
"toggle": "Toggle navigation menu"
1716
},
1817
"links": {
1918
"about": "About",

0 commit comments

Comments
 (0)