Skip to content

Commit 35d5ddb

Browse files
authored
types: add SnapshotRecorderMode (#4442)
* types: add SnapshotRecorderMode * fix types
1 parent 66181d2 commit 35d5ddb

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

test/types/snapshot-agent.test-d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ expectAssignable<Dispatcher>(new SnapshotAgent())
6262
expectType<Promise<void>>(snapshotAgent.loadSnapshots())
6363
expectType<Promise<void>>(snapshotAgent.loadSnapshots('./custom.json'))
6464
expectType<SnapshotRecorder>(snapshotAgent.getRecorder())
65-
expectType<'record' | 'playback' | 'update'>(snapshotAgent.getMode())
65+
expectType<SnapshotRecorder.SnapshotRecorderMode>(snapshotAgent.getMode())
6666
expectType<void>(snapshotAgent.clearSnapshots())
6767

6868
// New snapshot management methods
@@ -361,9 +361,9 @@ expectAssignable<SnapshotAgent.Options>({
361361
const playbackAgent = new SnapshotAgent({ mode: 'playback', snapshotPath: './test.json' })
362362
const updateAgent = new SnapshotAgent({ mode: 'update', snapshotPath: './test.json' })
363363

364-
expectType<'record' | 'playback' | 'update'>(recordAgent.getMode())
365-
expectType<'record' | 'playback' | 'update'>(playbackAgent.getMode())
366-
expectType<'record' | 'playback' | 'update'>(updateAgent.getMode())
364+
expectType<SnapshotRecorder.SnapshotRecorderMode>(recordAgent.getMode())
365+
expectType<SnapshotRecorder.SnapshotRecorderMode>(playbackAgent.getMode())
366+
expectType<SnapshotRecorder.SnapshotRecorderMode>(updateAgent.getMode())
367367
}
368368

369369
{

types/snapshot-agent.d.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@ declare class SnapshotRecorder {
1818
}
1919

2020
declare namespace SnapshotRecorder {
21+
type SnapshotRecorderMode = 'record' | 'playback' | 'update'
22+
2123
export interface Options {
2224
snapshotPath?: string
23-
mode?: 'record' | 'playback' | 'update'
25+
mode?: SnapshotRecorderMode
2426
maxSnapshots?: number
2527
autoFlush?: boolean
2628
flushInterval?: number
@@ -77,7 +79,7 @@ declare class SnapshotAgent extends MockAgent {
7779
saveSnapshots (filePath?: string): Promise<void>
7880
loadSnapshots (filePath?: string): Promise<void>
7981
getRecorder (): SnapshotRecorder
80-
getMode (): 'record' | 'playback' | 'update'
82+
getMode (): SnapshotRecorder.SnapshotRecorderMode
8183
clearSnapshots (): void
8284
resetCallCounts (): void
8385
deleteSnapshot (requestOpts: any): boolean
@@ -87,7 +89,7 @@ declare class SnapshotAgent extends MockAgent {
8789

8890
declare namespace SnapshotAgent {
8991
export interface Options extends MockAgent.Options {
90-
mode?: 'record' | 'playback' | 'update'
92+
mode?: SnapshotRecorder.SnapshotRecorderMode
9193
snapshotPath?: string
9294
maxSnapshots?: number
9395
autoFlush?: boolean

0 commit comments

Comments
 (0)