first review

Author: AugustinMauroy

package-lock.json

@@ -1,9 +1,9 @@
 {
   "$schema": "https://codemod-utils.s3.us-west-1.amazonaws.com/configuration_schema.json",
-  "name": "@nodejs/import-attributes",
-  "description": "Replace erroneous 'js' or omitted file extensions of import specifiers in TypeScript files.",
+  "name": "@nodejs/import-assertions-to-attributes",
+  "description": "",
   "version": "1.0.0",
-  "engine": "workflow",
+  "engine": "ast-grep",
   "private": false,
   "entry": "./src/workflow.ts",
   "arguments": [],
@@ -12,8 +12,7 @@
     "tags": [
       "esm",
       "import",
-      "node",
-      "typescript"
+      "node"
     ]
   }
 }

recipes/import-attributes/.codemodrc.json renamed to recipes/import-assertions-to-attributes/.codemodrc.json

@@ -1,5 +1,5 @@
 {
-  "name": "@nodejs/import-attributes",
+  "name": "@nodejs/import-assertions-to-attributes",
   "version": "1.0.0",
   "description": "Replace  `assert` import arrtibute to the `with` ECMAScript import attribute.",
   "type": "module",
@@ -14,7 +14,7 @@
   "repository": {
     "type": "git",
     "url": "git+https://github.com/nodejs/userland-migrations.git",
-    "directory": "recipes/import-attributes",
+    "directory": "recipes/import-assertions-to-attributes",
     "bugs": "https://github.com/nodejs/userland-migrations/issues"
   },
   "files": [
@@ -24,12 +24,11 @@
   ],
   "keywords": [
     "codemod",
-    "esm",
-    "typescript"
+    "esm"
   ],
-  "author": "Jacob Smith",
+  "author": "Augustin Mauroy",
   "license": "MIT",
-  "homepage": "https://github.com/nodejs/userland-migrations/tree/main/import-attributes#readme",
+  "homepage": "https://github.com/nodejs/userland-migrations/tree/main/import-assertions-to-attributes#readme",
   "devDependencies": {
     "@types/node": "^24.0.3"
   },

recipes/import-attributes/package.json renamed to recipes/import-assertions-to-attributes/package.json

@@ -12,6 +12,7 @@ async function processModule({ astGrep }: Helpers) {
             any: [
 				// cover `import { something } from './module.json' assert { type: 'json' };`
                 { kind: 'import_statement', regex: "import\\s+.*\\s+assert\\s*\\{" },
+				{ kind: 'import_statement', regex: "import\\s+.*\\s+with\\s*\\{" },
 				// cover `import('./module.json', { assert: { type: 'json' } })`
 				{
 					kind: 'call_expression', pattern: "import($SPECIFIER, { assert: $ASSERT })",
@@ -25,10 +26,11 @@ async function processModule({ astGrep }: Helpers) {
 
 		if (kind === 'import_statement') {
 			// Modify import statement with assert
-
+			const children = node.children();
+			console.log(children.map(child => child.kind()));
 		} else if (kind === 'call_expression') {
 			// Modify dynamic import with assert
-			const children = node.children();
+			/*const children = node.children();
 
 			if (children.length > 2) {
 				throw new Error(`Expected 2 children, got ${children.length}`);
@@ -57,8 +59,7 @@ async function processModule({ astGrep }: Helpers) {
 
 			// Replace "assert" with "with" and keep the same value
 			const newTypePair = `with: ${assertValue.text()}`;
-			edits.push(assertPair.replace(newTypePair));
-
+			edits.push(assertPair.replace(newTypePair));*/
 		} else {
 			throw new Error(`Unexpected node kind: ${node.kind}`);
 		}
@@ -88,11 +89,11 @@ async function processModule({ astGrep }: Helpers) {
  */
 export async function workflow({ files }: Api) {
 	console.log(
-		`${styleText(["bold", "blue"], "[import-attributes]")}: Modifying import attributes to use 'with' instead of 'assert'`,
+		`${styleText(["bold", "blue"], "[import-assertions-to-attributes]")}: Modifying import attributes to use 'with' instead of 'assert'`,
 	);
 	await files(globPattern).jsFam(processModule);
 	console.log(
-		`${styleText(["bold", "blue"], "[import-attributes]")}: Finished modifying import attributes`,
+		`${styleText(["bold", "blue"], "[import-assertions-to-attributes]")}: Finished modifying import attributes`,
 	);
 };
 

recipes/import-attributes/src/workflow.ts renamed to recipes/import-assertions-to-attributes/src/workflow.ts

@@ -1,5 +1,6 @@
 import { createRequire } from 'node:module';
 import data from './data.json' assert { type: 'json' };
+import cacaDeMerde from './caca-de-merde.js' with { type: 'json' };
 const require = createRequire(import.meta.url);
 const foo = require('./foo.js');
 

recipes/import-attributes/tests/fixtures/file-edge-case.js renamed to recipes/import-assertions-to-attributes/tests/fixtures/file-edge-case.js

@@ -7,7 +7,7 @@ import { spawnPromisified } from '../../../test/spawn-promisified.ts';
 
 const fixturesDir = new URL("./fixtures", import.meta.url);
 
-describe("workflow - import-attributes", async () => {
+describe("workflow - import-assertions-to-attributes", async () => {
 	await spawnPromisified(
 		execPath,
 		[