Skip to content

Commit b900281

Browse files
committed
Restore bats-support as explicit devDep
It was removed because npm 7+ now installs peer deps by default, and bats-support is a peerDep of bats-assert. However, that implies a version restriction that this plugin depends on npm 7+. But that restriction only applies to _development_. We could put the restriction on bats-assert, (which would be more aligned with it as a dev dep). But it's not technically true because any dependent of bats-assert could avoid the npm restriction by simply installing bats-support _explicitly_. Which leads us back to the main point. bats-support is loaded _from_ the parent dependent. So it should be an explicit devDep at that location.
1 parent f9bfeb5 commit b900281

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

package-lock.json

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
"bats": "^1.12.0",
3939
"bats-assert": "^2.2.0",
4040
"bats-mock": "^1.2.5",
41+
"bats-support": "^0.3.0",
4142
"prettier": "^3.6.2",
4243
"shellcheck": "^3.1.0"
4344
}

0 commit comments

Comments
 (0)