Skip to content

Commit 298fe3a

Browse files
authored
Apply suggestions from code review
1 parent eec66a0 commit 298fe3a

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed

src/Deeptable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export class Deeptable {
188188
const batch = await this.root_tile.get_arrow(null);
189189
const schema = batch.schema;
190190
// TODO: Cleaner check that it's a lazy manifest
191-
if (!flatManifest[0]) {
191+
if (!flatManifest[0]) { // An empty flatManifest indicates a legacy (or missing) manifest and triggers derivation of metadata.
192192
this.root_tile.metadata =
193193
await this.root_tile.deriveManifestInfoFromTileMetadata();
194194
}

src/scatterplot.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ export class Scatterplot {
373373
tileProxy,
374374
}: DS.DataSpec): Promise<DS.Deeptable> {
375375
if (source_url !== undefined) {
376-
console.log('Loading from source url', source_url);
377376
this._root = await Deeptable.fromQuadfeather({
378377
baseUrl: source_url,
379378
plot: this,

src/tile.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ export class Tile {
298298
manifest: TileMetadata | (TileMetadata & { extent: Rectangle }),
299299
) {
300300
// Setting the manifest is the thing that spawns children.
301-
console.log(manifest.max_ix);
302301
this.highest_known_ix = manifest.max_ix;
303302
this._metadata = {
304303
...manifest,
@@ -480,7 +479,6 @@ export class Tile {
480479
if (this._metadata) {
481480
return;
482481
}
483-
console.log('Populating', this.key);
484482
this.metadata = await this.deriveManifestInfoFromTileMetadata();
485483
}
486484

src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ export type DeeptableCreateParams = {
9999
// may be inferred.
100100
tileStructure?: TileStructure;
101101

102-
// A manifest listing all the tiles in the deeptable.
103-
// Currently this must be passed as a recursive structure.
102+
// A manifest listing all the tiles in the deeptable, of the type created by
103+
// quadfeather v2.0.0 or greater.
104104
tileManifest?: Table;
105105

106106
// A URL for an arrow file manifest. The schema for this manifest

0 commit comments

Comments
 (0)