Skip to content

Fixes creating a KB from an Import #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fixes creating a KB from an Import #2778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d0300
Fixes creating a KB from an Import
Jan 15, 2025
c55416f
Merge branch 'main' into fix-import
carlesonielfa Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions nucliadb/src/nucliadb/writer/api/v1/knowledgebox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,16 @@ async def create_kb(item: KnowledgeBoxConfig) -> tuple[str, str]:
if "semantic_model" in user_learning_config:
user_learning_config["semantic_models"] = [user_learning_config.pop("semantic_model")]

deprecated_keys = [
"semantic_vector_similarity",
"semantic_vector_size",
"semantic_matryoshka_dimensions",
"semantic_model_configs",
"semantic_threshold",
]
for key in deprecated_keys:
user_learning_config.pop(key, None)

# we rely on learning to return the updated configuration with defaults and
# any other needed values (e.g. matryoshka settings if available)
learning_config = await learning_proxy.set_configuration(kbid, config=user_learning_config)
Expand Down
Loading