Skip to content

Conversation

@jotare
Copy link
Contributor

@jotare jotare commented Apr 11, 2025

Description

VersionedFastAPI was giving us more trouble than benefit. A simple prefix in our routers replaces the functionality we were using from VersionedFastAPI. In addition, removing this fixes a subtle bug where two FastAPIs were created with the same middleware, causing multiple calls to those middlewares (auth, audit...) per request.

How was this PR tested?

Describe how you tested this PR.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 27 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (cd5cfda) to head (01049ed).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...iadb_telemetry/src/nucliadb_telemetry/jetstream.py 50.00% 13 Missing ⚠️
nucliadb/src/nucliadb/train/app.py 0.00% 8 Missing ⚠️
nucliadb/src/nucliadb/search/openapi.py 0.00% 2 Missing ⚠️
nucliadb/src/nucliadb/search/run.py 0.00% 2 Missing ⚠️
nucliadb/src/nucliadb/train/run.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   84.19%   84.06%   -0.13%     
==========================================
  Files         502      503       +1     
  Lines       37847    37742     -105     
  Branches    11808    11808              
==========================================
- Hits        31865    31729     -136     
- Misses       5427     5457      +30     
- Partials      555      556       +1     
Flag Coverage Δ
nidx 78.12% <ø> (-0.01%) ⬇️
nucliadb 76.65% <66.66%> (-0.22%) ⬇️
nucliadb-ingest 41.46% <25.92%> (-0.41%) ⬇️
nucliadb-reader 41.31% <48.14%> (-0.48%) ⬇️
nucliadb-search 44.81% <40.74%> (-0.44%) ⬇️
nucliadb-standalone 45.46% <46.29%> (-0.42%) ⬇️
nucliadb-train 44.15% <44.44%> (-0.41%) ⬇️
nucliadb-writer 46.46% <31.48%> (-0.28%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 79.05% <ø> (ø)
nucliadb_sdk 93.13% <ø> (ø)
nucliadb_telemetry 85.48% <50.00%> (-1.02%) ⬇️
nucliadb_utils 84.86% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare jotare force-pushed the add-telemetry-to-tests branch from e75c293 to 01049ed Compare April 15, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants