Customize Cards components #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/cards
branch
4 times, most recently
from
a5b6520 to
c06fadb
Compare
lubej
reviewed
Oct 25, 2025
|
|
||
| type CardTitleProps = React.ComponentProps<typeof BaseCardTitle> | ||
|
|
||
| export const CardTitle = ({ className, ...props }: CardTitleProps) => ( |
Collaborator
There was a problem hiding this comment.
The card "With action" story looks kinda broken: https://6d790ebb.oasis-ui.pages.dev/iframe?viewMode=docs&id=components-card--docs&globals=#with-action
Collaborator
Author
There was a problem hiding this comment.
welp it's how radix/shadcn card works. Now issue is more visible due to text-sm in content. CardContent affects Card width, CardHeader is having layout issues due to grid display. I did not find any magic tailwind class to fix that nicely. We can use two workarounds:
- control min-w on component level in app/storybook if content is very short
- overwrite radix/shadcn layout of CardsHader/Title/Action
I would go with 1 tbh because 2 is less predictible
https://bf5f8bfa.oasis-ui.pages.dev/?path=/story/components-card--with-action
kaja-osojnik
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for oasisprotocol/explorer#2278