Skip to content

Conversation

@dosumis
Copy link
Contributor

@dosumis dosumis commented Mar 17, 2025

Added new term for conducting airway epithelium + attempts at related refactoring. DRAFT!
#3491

Added new term for conducting airway epithelium + attempts at related refactoring.  DRAFT!
@dosumis dosumis marked this pull request as draft March 17, 2025 13:59
@dosumis
Copy link
Contributor Author

dosumis commented Mar 17, 2025

#gogoeditdiff

@github-actions github-actions bot requested a review from cmungall March 17, 2025 14:02
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes detected in src/ontology/uberon-edit.obo involving intersection_of. Review by specific Uberon Core Team member is required.

@dosumis
Copy link
Contributor Author

dosumis commented Mar 17, 2025

Hi @cmungall - still very much draft. Disentangling this stuff is hard!

@github-actions
Copy link
Contributor

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-03-17/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-03-17/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

conducting airway epithelium http://purl.obolibrary.org/obo/UBERON_1100003

Added

endothelium of main bronchus http://purl.obolibrary.org/obo/UBERON_0003280

Removed

Added

endothelium of trachea http://purl.obolibrary.org/obo/UBERON_0003279

Removed

Added

epithelium of bronchiole http://purl.obolibrary.org/obo/UBERON_0002051

Added

epithelium of bronchus http://purl.obolibrary.org/obo/UBERON_0002031

Removed

Added

epithelium of lobar bronchus http://purl.obolibrary.org/obo/UBERON_0002339

Removed

Added

epithelium of lobular bronchiole http://purl.obolibrary.org/obo/UBERON_8600001

Removed

Added

epithelium of main bronchus http://purl.obolibrary.org/obo/UBERON_0002340

Removed

Added

epithelium of nasopharynx http://purl.obolibrary.org/obo/UBERON_0001951

Added

epithelium of segmental bronchus http://purl.obolibrary.org/obo/UBERON_0002341

Removed

Added

epithelium of trachea http://purl.obolibrary.org/obo/UBERON_0001901

Removed

Added

left lung lobar bronchus epithelium http://purl.obolibrary.org/obo/UBERON_0015794

Removed

Added

nasal cavity respiratory epithelium http://purl.obolibrary.org/obo/UBERON_0005385

Added

olfactory epithelium http://purl.obolibrary.org/obo/UBERON_0001997

Added

pseudostratified ciliated epithelium of larynx http://purl.obolibrary.org/obo/UBERON_1100004

Added

respiratory tract epithelium http://purl.obolibrary.org/obo/UBERON_0004802

Removed

Added

right lung lobar bronchus epitheium http://purl.obolibrary.org/obo/UBERON_0015795

Removed

Added

terminal bronchus epithelium http://purl.obolibrary.org/obo/UBERON_0004818

Removed

Added

@github-actions
Copy link
Contributor

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

conducting airway epithelium http://purl.obolibrary.org/obo/UBERON_1100003

Added

epithelium of bronchus http://purl.obolibrary.org/obo/UBERON_0002031

Removed

Added

epithelium of lobar bronchus http://purl.obolibrary.org/obo/UBERON_0002339

Removed

Added

epithelium of lobular bronchiole http://purl.obolibrary.org/obo/UBERON_8600001

Removed

Added

epithelium of main bronchus http://purl.obolibrary.org/obo/UBERON_0002340

Removed

Added

epithelium of segmental bronchus http://purl.obolibrary.org/obo/UBERON_0002341

Removed

Added

epithelium of trachea http://purl.obolibrary.org/obo/UBERON_0001901

Removed

Added

left lung lobar bronchus epithelium http://purl.obolibrary.org/obo/UBERON_0015794

Removed

Added

pseudostratified ciliated epithelium of larynx http://purl.obolibrary.org/obo/UBERON_1100004

Added

respiratory tract epithelium http://purl.obolibrary.org/obo/UBERON_0004802

Removed

Added

right lung lobar bronchus epitheium http://purl.obolibrary.org/obo/UBERON_0015795

Removed

Added

@cmungall
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants