-
Notifications
You must be signed in to change notification settings - Fork 34
Add cochlear nerve root term (UBERON:7770009) #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added new term 'cochlear nerve root' with definition based on validated assertions from Aurelian analysis of literature. Definition includes only assertions confirmed by reference PMID:27289629. Term is classified as a nerve root and is part of the brain. Addresses #3570 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@RiveraAndrea83 - I think I might have asked the agent to do too much. Would have been better to use my brain to edit down :) . |
src/ontology/uberon-edit.obo
Outdated
| [Term] | ||
| id: UBERON:7770009 | ||
| name: cochlear nerve root | ||
| namespace: uberon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) That namespace tag is not needed, since uberon is already the default namespace in the entire file. Not sure where the agent took the “inspiration” for that tag, given that no other term frame in uberon-edit.obo has such a tag.
(2) That tag causes the check-obo-for-standard-release.pl script to raise an error because it perceives the term as having a different namespace than its UBERON:0002211 parent. (The correctness of that check is dubious: yes, UBERON:0002211 does not have an explicit namespace, but it does inherit the default namespace declared in the header, and therefore is in fact in the uberon namespace – but apparently the script only takes into account term-level namespace tags, not the default namespace.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@dragon-ai-agent please update the PR (do not make a new PR, check out this branch and commit here). I have updated your instructions. I mistakenly told you to add a |
As pointed out by @gouttegd, namespace tags are not standard practice in this ontology. Removed the namespace tag from the cochlear nerve root term to follow proper UBERON conventions. @dragon-ai-agent
|
Updated the cochlear nerve root term (UBERON:7770009) to remove the namespace tag as pointed out by @gouttegd. This follows proper UBERON conventions - namespace tags are not standard practice in this ontology. The term now properly follows the standard format without the namespace tag. |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Summary
Details
Based on the Aurelian validation in the issue comments, I included only the assertions that were confirmed:
The definition excludes unvalidated assertions about nerve structure and fiber bifurcation that could not be confirmed by the reference paper.
Test plan
Closes #3570
🤖 Generated with Claude Code