Implementation to get list of possible jumps#1891
Open
PizieDust wants to merge 8 commits intoocaml:mainfrom
Open
Implementation to get list of possible jumps#1891PizieDust wants to merge 8 commits intoocaml:mainfrom
PizieDust wants to merge 8 commits intoocaml:mainfrom
Conversation
xvw
reviewed
Jan 31, 2025
Comment on lines
+180
to
+181
| | Some loc -> `Found loc | ||
| | None -> `Error ("No matching case found for " ^ target) |
Collaborator
There was a problem hiding this comment.
I know that it is not particularly related to this PR but just out of curiosity, why going for a polymorphic variant? It looks like result is sufficient here no?
Contributor
Author
There was a problem hiding this comment.
I think we can correct this in a different PR. But I just maintained what was already used, which was the variant
xvw
reviewed
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1817
Add a new function
get_allthat returns all the possible jump targets in a code buffer.In some client implementations, we repeatedly query the
Jumpcommand of Merlin which means many trips to the server from the client. This new function ensures that we only make the trip once and we get all the information we need.cc @voodoos