-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Writing down some thoughts about some optimizations which can be done:
-
API endpoints are currently hardcoded which isn't optimal but doesn't really detract from the function of the program. The endpoints aren't exactly sensitive as they don't require authentication query. Though the information does come from the DGS -> Prometheus, a request which does require authentication, the information served by DGS -> Labmap2 Server is limited scope enough where it is no longer sensitive (was it ever really?). The same information obtained by the open DGS can be gleaned by just walking into the OCF.
-
Building can be integrated into the CI/CD pipeline as Godot offers a way to compile in CLI, so it can definitely be thrown into the steps of a Dockerfile as a part of the labmap2_server Dockerfile.
-
I dislike how I designed the Labmap2 -> DGS querying, it uses a polling function which is noisy. See the script http_request_node.gd for more information, this is the tip of the iceberg.