return in finally can swallow exceptions

[iritkatriel]

In

HtmlTestRunner/HtmlTestRunner/result.py

Line 32 in 8529dc3

return file

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if a BaseException (such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.