Skip to content

Fix function comments based on best practices from Effective Go #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix function comments based on best practices from Effective Go #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nanomsg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (s *Socket) Bind(address string) (*Endpoint, error) {
return &Endpoint{address, eid}, nil
}

// Add a remote endpoint to the socket.
// Connect adds a remote endpoint to the socket.
func (s *Socket) Connect(address string) (*Endpoint, error) {
cstr := C.CString(address)
defer C.free(unsafe.Pointer(cstr))
Expand All @@ -123,7 +123,7 @@ func (s *Socket) Connect(address string) (*Endpoint, error) {
return &Endpoint{address, eid}, nil
}

// Removes an endpoint from the socket. This call will return immediately,
// Shutdown removes an endpoint from the socket. This call will return immediately,
// however, the library will try to deliver any outstanding outbound messages
// to the endpoint for the time specified by the linger socket option.
func (s *Socket) Shutdown(endpoint *Endpoint) error {
Expand Down