Refactor template-based addon handling to avoid breaking interface changes

- Move templateBasedAddOn parameter from interface to concrete implementation
- Add SetTemplateBasedAddOn() method to BaseAddonManager interface
- Add templateBasedAddOn field to BaseAddonManagerImpl struct
- Revert StartWithInformers interface to original signature
- Update all callers to use the original interface method
- Maintain backward compatibility while providing new functionality

This allows users to configure template-based addon handling through the
public API without breaking existing external implementations:

  manager, _ := addonmanager.New(config)
  manager.SetTemplateBasedAddOn(true)  // Enable template filtering
  manager.StartWithInformers(ctx, ...) // Uses configured setting

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: zhujian <[email protected]>

Author: zhujian7

pkg/addonmanager/base_manager.go

@@ -29,10 +29,11 @@ import (
 // BaseAddonManagerImpl is the base implementation of BaseAddonManager
 // that manages the addon agents and configs.
 type BaseAddonManagerImpl struct {
-	addonAgents  map[string]agent.AgentAddon
-	addonConfigs map[schema.GroupVersionResource]bool
-	config       *rest.Config
-	syncContexts []factory.SyncContext
+	addonAgents        map[string]agent.AgentAddon
+	addonConfigs       map[schema.GroupVersionResource]bool
+	config             *rest.Config
+	syncContexts       []factory.SyncContext
+	templateBasedAddOn bool
 }
 
 // NewBaseAddonManagerImpl creates a new BaseAddonManagerImpl instance with the given config.
@@ -71,18 +72,30 @@ func (a *BaseAddonManagerImpl) Trigger(clusterName, addonName string) {
 	}
 }
 
+// SetTemplateBasedAddOn configures whether the manager is handling template-based addons.
+//   - true: all ManagedClusterAddOn controllers except "addon-config-controller" will only process addons
+//     when the referenced AddOnTemplate resources in their status.configReferences are properly set;
+//     the "addon-config-controller" is responsible for setting these values
+//   - false: process all addons without waiting for template configuration
+//
+// This prevents premature processing of template-based addons before their configurations
+// are fully ready, avoiding unnecessary errors and retries.
+// See https://github.com/open-cluster-management-io/ocm/issues/1181 for more context.
+func (a *BaseAddonManagerImpl) SetTemplateBasedAddOn(templateBasedAddOn bool) {
+	a.templateBasedAddOn = templateBasedAddOn
+}
+
 func (a *BaseAddonManagerImpl) StartWithInformers(ctx context.Context,
 	workClient workclientset.Interface,
 	workInformers workv1informers.ManifestWorkInformer,
 	kubeInformers kubeinformers.SharedInformerFactory,
 	addonInformers addoninformers.SharedInformerFactory,
 	clusterInformers clusterv1informers.SharedInformerFactory,
 	dynamicInformers dynamicinformer.DynamicSharedInformerFactory,
-	templateBasedAddOn bool,
 ) error {
-	// Determine the appropriate filter function based on templateBasedAddOn flag
+	// Determine the appropriate filter function based on templateBasedAddOn field
 	mcaFilterFunc := utils.AllowAllAddOns
-	if templateBasedAddOn {
+	if a.templateBasedAddOn {
 		mcaFilterFunc = utils.FilterTemplateBasedAddOns
 	}
 

pkg/addonmanager/cloudevents/manager.go

@@ -177,7 +177,7 @@ func (a *cloudeventsAddonManager) Start(ctx context.Context) error {
 	}
 
 	err = a.StartWithInformers(ctx, workClient, workInformers, kubeInformers, addonInformers, clusterInformers,
-		dynamicInformers, false)
+		dynamicInformers)
 	if err != nil {
 		return err
 	}

pkg/addonmanager/interface.go

@@ -22,24 +22,17 @@ type BaseAddonManager interface {
 	// only trigger the deploy controller.
 	Trigger(clusterName, addonName string)
 
+	// SetTemplateBasedAddOn configures whether the manager is handling template-based addons.
+	SetTemplateBasedAddOn(templateBasedAddOn bool)
+
 	// StartWithInformers starts all registered addon agent with the given informers.
-	//
-	// templateBasedAddOn controls whether the manager is handling template-based addons:
-	// - true: all ManagedClusterAddOn controllers except "addon-config-controller" will only process addons
-	//   when the referenced AddOnTemplate resources in their status.configReferences are properly set;
-	//   the "addon-config-controller" is responsible for setting these values
-	// - false: process all addons without waiting for template configuration
-	// This filtering prevents premature processing of template-based addons before their configurations
-	// are fully ready, avoiding unnecessary errors and retries.
-	// See https://github.com/open-cluster-management-io/ocm/issues/1181 for more context.
 	StartWithInformers(ctx context.Context,
 		workClient workclientset.Interface,
 		workInformers workv1informers.ManifestWorkInformer,
 		kubeInformers kubeinformers.SharedInformerFactory,
 		addonInformers addoninformers.SharedInformerFactory,
 		clusterInformers clusterv1informers.SharedInformerFactory,
 		dynamicInformers dynamicinformer.DynamicSharedInformerFactory,
-		templateBasedAddOn bool,
 	) error
 }
 

pkg/addonmanager/manager.go

@@ -123,7 +123,7 @@ func (a *addonManager) Start(ctx context.Context) error {
 	}
 
 	err = a.StartWithInformers(ctx, workClient, workInformers.Work().V1().ManifestWorks(), kubeInformers,
-		addonInformers, clusterInformers, dynamicInformers, false)
+		addonInformers, clusterInformers, dynamicInformers)
 	if err != nil {
 		return err
 	}