Skip to content

Commit a5e9a40

Browse files
committed
updated
1 parent 2308fb0 commit a5e9a40

File tree

1 file changed

+5
-4
lines changed
  • enhancements/sig-architecture/227-manifestworkreplicaset-rollout-plugin

1 file changed

+5
-4
lines changed

enhancements/sig-architecture/227-manifestworkreplicaset-rollout-plugin/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,19 +143,21 @@ sequenceDiagram
143143
Note over Work, PluginServer: Start automatic abort
144144
Work->>Work: Set .status.abort to true
145145
Work->>Work: Set .status.abortedTime to the current time
146+
Work->>Work: Update the desired revision to `.status.currentRevision`
146147
end
147148
alt is normal rollout? (.status.abort == false)
148149
Work->>PluginServer: (NEW) ProgressRollout()
150+
PluginServer-->>Work: OK
149151
else is abort operation? (.status.abort == true)
150152
Work->>PluginServer: (NEW) ProgressAbort()
153+
PluginServer-->>Work: OK
151154
end
152-
PluginServer-->>Work: OK
153155
alt is normal rollout? (.status.abort == false)
154156
Note over Work, PluginServer: Normal Rollout
155157
loop clusterToRollout clusters
156158
Work->>PluginServer: (NEW) BeginRollout()
157159
PluginServer-->>Work: OK
158-
Work->>PluginServer: (NEW) MutateManifestwork()
160+
Work->>PluginServer: (NEW) MutateManifestwork(the desired revision)
159161
PluginServer-->>Work: (NEW) Return mutated Manifestwork resource
160162
Work->>APIServer: Apply the mutated ManifestWork resource to the current cluster
161163
end
@@ -164,7 +166,7 @@ sequenceDiagram
164166
loop existing clusters (updated clusters)
165167
Work->>PluginServer: (NEW) BeginAbort()
166168
PluginServer-->>Work: OK
167-
Work->>PluginServer: (NEW) MutateManifestwork()
169+
Work->>PluginServer: (NEW) MutateManifestwork(the desired revision)
168170
PluginServer-->>Work: (NEW) Return mutated Manifestwork resource
169171
Work->>APIServer: Apply the mutated ManifestWork resource to the current cluster
170172
end
@@ -176,7 +178,6 @@ sequenceDiagram
176178

177179
This workflow introduces four new plugin API calls:
178180

179-
180181
* `BeginRollout()`: Called before applying the ManifestWork to a target cluste to roll out new revision, allowing the plugin to perform any necessary preparations.
181182
* `ProgressRollout()`: Called during every reconciliation loop to report the current rollout status to the plugin.
182183
* `ValidateRolloutCompletion()`: Called after the `Progressing` condition on the target cluster's ManifestWork becomes False. This hook enables post-rollout testing before the status is set to Succeeded. For example, the plugin could use this call to create a new ManifestWork that runs a Kubernetes Job for verification. **Note that this hook must be called within the `ProgressDeadline` timeout.**

0 commit comments

Comments
 (0)