Skip to content

Commit d9aec9e

Browse files
committed
wip
1 parent bf3d576 commit d9aec9e

File tree

1 file changed

+3
-5
lines changed
  • enhancements/sig-architecture/227-manifestworkreplicaset-rollout-plugin

1 file changed

+3
-5
lines changed

enhancements/sig-architecture/227-manifestworkreplicaset-rollout-plugin/README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,7 @@ The plugin hook APIs will identify the ManifestWorkReplicaSet being processed wi
243243

244244
#### Error handling
245245

246-
gRPC status codes follow the [standard gRPC status codes](https://grpc.github.io/grpc/core/md_doc_statuscodes.html): 0 = OK, 1 = CANCELLED, 2 = UNKNOWN, 3 = INVALID_ARGUMENT, 4 = DEADLINE_EXCEEDED, etc.
247-
Work controller will also utilize the [standard gRPC retry](https://grpc.io/docs/guides/retry/) for `UNAVAILABLE` status code.
248-
246+
gRPC status codes follow the [standard gRPC status codes](https://grpc.github.io/grpc/core/md_doc_statuscodes.html): 0 = OK, 1 = CANCELLED, 2 = UNKNOWN, 3 = INVALID_ARGUMENT, 4 = DEADLINE_EXCEEDED, etc. Work controller will also utilize the [standard gRPC retry](https://grpc.io/docs/guides/retry/) for `UNAVAILABLE` status code.
249247
When work controller fails to call plugin APIs, the failure reason from plugin server is shown in `PluginLoaded` status condition message for debugging purpose.
250248

251249
### Register custom plugins for work controller
@@ -338,7 +336,7 @@ spec:
338336

339337
### Using plugin in MWRS
340338

341-
Plugin is an opt-in feature. User can use the registered plugin by setting `.spec.placementRefs[*].rolloutStrategy.plugin`.
339+
Plugin is an opt-in feature. User can use the registered plugin by setting `.spec.placementRefs[*].rolloutStrategy.plugin`. The reconciler makes sure that plugin is available and show its availability or error messages in `PluginLoaded` status condition type.
342340

343341
```yaml
344342
apiVersion: work.open-cluster-management.io/v1
@@ -364,7 +362,7 @@ status:
364362
type: PluginLoaded
365363
```
366364

367-
The reconciler makes sure that plugin is available and show its availability or error messages in `PluginLoaded` status condition like below:
365+
The following example shows `Available` and `Failed` reasons for `PluginLoaded` status condition type
368366

369367
| Reason | Status | Message |
370368
| --- | --- | --- |

0 commit comments

Comments
 (0)