-
Notifications
You must be signed in to change notification settings - Fork 846
feat(inspect): dataset list virtualization #3191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inspect): dataset list virtualization #3191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements virtualization for the dataset list to improve performance when handling large datasets. The changes introduce paginated loading of media items and replace the grid-based layout with a virtualized grid layout that renders items on demand.
Key Changes:
- Implemented virtualized grid layout for dataset list with pagination support
- Added conditional rendering of inference devices based on model availability
- Refactored project management components to extract reusable pieces
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
application/ui/src/features/inspect/utils.ts |
Added shared getThumbnailUrl utility function |
application/ui/src/features/inspect/toolbar/toolbar.tsx |
Added conditional rendering for InferenceDevices component |
application/ui/src/features/inspect/toolbar/toolbar.test.tsx |
Added tests for conditional InferenceDevices rendering |
application/ui/src/features/inspect/toolbar/inference-devices/inference-devices.component.tsx |
Added aria-label for accessibility |
application/ui/src/features/inspect/sidebar.component.tsx |
Commented out Stats tab temporarily |
application/ui/src/features/inspect/dataset/hooks/use-get-media-items.hook.tsx |
Implemented hook for paginated media items loading |
application/ui/src/features/inspect/dataset/dataset.component.tsx |
Removed inline hook in favor of new hook |
application/ui/src/features/inspect/dataset/dataset-list.component.tsx |
Replaced Grid with VirtualizerGridLayout for performance |
application/ui/src/features/inspect/dataset/dataset-item-placeholder/* |
Extracted placeholder component to separate directory |
application/ui/src/features/inspect/projects-management/* |
Refactored project editing and add button to separate components |
application/ui/src/components/virtualizer-grid-layout/grid-media-item/grid-media-item.module.scss |
Added background color to floating container |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tion/ui/src/features/inspect/dataset/media-preview/sidebar-items/sidebar-items.component.tsx
Outdated
Show resolved
Hide resolved
9c5e647 to
7a7a318
Compare
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
7a7a318 to
47ad106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Colorado, Camilo <[email protected]>
47ad106 to
c08c8bb
Compare
3c79f7d
into
open-edge-platform:feature/geti-inspect
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 Description
This PR implements virtualization for the dataset list and loads items using pagination.
Screen.Recording.2025-12-04.at.14.40.03.mov
#3178
#3173
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.