Skip to content

Conversation

@camiloHimura
Copy link

📝 Description

This PR implements virtualization for the dataset list and loads items using pagination.

Screen.Recording.2025-12-04.at.14.40.03.mov

#3178
#3173

  • Provide a clear summary of the changes and the issue that has been addressed.
  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements virtualization for the dataset list to improve performance when handling large datasets. The changes introduce paginated loading of media items and replace the grid-based layout with a virtualized grid layout that renders items on demand.

Key Changes:

  • Implemented virtualized grid layout for dataset list with pagination support
  • Added conditional rendering of inference devices based on model availability
  • Refactored project management components to extract reusable pieces

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
application/ui/src/features/inspect/utils.ts Added shared getThumbnailUrl utility function
application/ui/src/features/inspect/toolbar/toolbar.tsx Added conditional rendering for InferenceDevices component
application/ui/src/features/inspect/toolbar/toolbar.test.tsx Added tests for conditional InferenceDevices rendering
application/ui/src/features/inspect/toolbar/inference-devices/inference-devices.component.tsx Added aria-label for accessibility
application/ui/src/features/inspect/sidebar.component.tsx Commented out Stats tab temporarily
application/ui/src/features/inspect/dataset/hooks/use-get-media-items.hook.tsx Implemented hook for paginated media items loading
application/ui/src/features/inspect/dataset/dataset.component.tsx Removed inline hook in favor of new hook
application/ui/src/features/inspect/dataset/dataset-list.component.tsx Replaced Grid with VirtualizerGridLayout for performance
application/ui/src/features/inspect/dataset/dataset-item-placeholder/* Extracted placeholder component to separate directory
application/ui/src/features/inspect/projects-management/* Refactored project editing and add button to separate components
application/ui/src/components/virtualizer-grid-layout/grid-media-item/grid-media-item.module.scss Added background color to floating container

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camiloHimura camiloHimura force-pushed the ccolora11/dataset-vitualization branch from 9c5e647 to 7a7a318 Compare December 5, 2025 11:49
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
@camiloHimura camiloHimura force-pushed the ccolora11/dataset-vitualization branch from 7a7a318 to 47ad106 Compare December 7, 2025 18:16
Copilot AI review requested due to automatic review settings December 7, 2025 18:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camiloHimura camiloHimura changed the title feat(inspect): dataset list vistualization feat(inspect): dataset list virtualization Dec 8, 2025
Signed-off-by: Colorado, Camilo <[email protected]>
@camiloHimura camiloHimura force-pushed the ccolora11/dataset-vitualization branch from 47ad106 to c08c8bb Compare December 8, 2025 15:15
@camiloHimura camiloHimura merged commit 3c79f7d into open-edge-platform:feature/geti-inspect Dec 8, 2025
21 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants