Skip to content

Commit ae05595

Browse files
authored
Fail on recursive make failures (#12)
1 parent f3044b6 commit ae05595

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

Makefile

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33

44
PROJECT_NAME := extensions
55
SUBPROJECTS := pkg/edgedns-coredns pkg/kubevirt-helper pkg/intel-gpu-debug
6-
VENV_NAME := venv_$(PROJECT_NAME)
6+
VENV_NAME := venv_$(PROJECT_NAME)
77
SCRIPTS_DIR := ./ci_scripts
88
LINT_DIRS := pkg/...
9+
SHELL := bash -eu -o pipefail
910

1011
# build virtualenv
1112
$(VENV_NAME): requirements.txt
@@ -25,13 +26,13 @@ build: docker-build helm-build ## Runs build stage
2526
docker-build:
2627
@# Help: Runs docker build stage
2728
@echo "---MAKEFILE DOCKER BUILD---"
28-
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir docker-build || exit $$?; done
29+
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir docker-build; done
2930
@echo "---END MAKEFILE DOCKER BUILD---"
3031

3132
docker-push:
3233
@# Help: Runs docker push stage
3334
@echo "---MAKEFILE DOCKER PUSH---"
34-
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir docker-push || exit $$?; done
35+
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir docker-push; done
3536
@echo "---END MAKEFILE DOCKER PUSH---"
3637

3738
helm-build:
@@ -58,7 +59,7 @@ artifact-publish: ## only runs in CI
5859
lint: yamllint mdlint helmlint go-lint ## Runs lint stage
5960
@# Help: Runs lint stage
6061
@echo "---MAKEFILE LINT---"
61-
@for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir lint || exit $$?; done
62+
@for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir lint; done
6263
@echo "---END MAKEFILE LINT---"
6364

6465
license: $(VENV_NAME) ## Check licensing with the reuse tool
@@ -72,13 +73,13 @@ list:
7273
clean:
7374
@# Help: Runs clean stage in all subprojects
7475
@echo "---MAKEFILE CLEAN---"
75-
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir clean || exit $$?; done
76+
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir clean; done
7677
@echo "---END MAKEFILE CLEAN---"
7778

7879
clean-all:
7980
@# Help: Runs clean-all stage in all subprojects
8081
@echo "---MAKEFILE CLEAN-ALL---"
81-
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir clean-all || exit $$?; done
82+
for dir in $(SUBPROJECTS); do $(MAKE) -C $$dir clean-all; done
8283
@echo "---END MAKEFILE CLEAN-ALL---"
8384

8485
define make-subproject-target

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.25
1+
1.0.26-dev

0 commit comments

Comments
 (0)