How do Github Reactions get handled?

[jsquyres]

Do we know if the new Github reactions get handled properly by the bot?

https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments

I'm guessing that there's some new flavor of notification that we should handle.

Should we update the bot to look for 👍 reactions to the main description (or any comment?) instead of 👍 inside comments?

[ggouaillardet]

I just added a +1 reaction to open-mpi/ompi-release#1020 but nothing happened ...
with the admin interface, you can see the full details of the json request that is related to this event,
can you find the request and copy it ?
I have no idea of what kind of event is generated ...

[jsquyres]

I wonder if we need to enable more hook events?

Here's the options (taken from the ompi-release settings page):

[jsquyres]

More specifically, I don't see a github webook being delivered (i.e., it's not in the logs).

How about I make you an admin on the ompi-release-bot repo? Then you can play with all the hooks.

...done.

[ggouaillardet]

👍

[ompiteam-bot]

OMPIBot error: Label "reviewed" is already set on issue 13.

[ggouaillardet]

i configured to "send me everything" but nothing is emitted when there is a reaction
I guess github folks did not update the api yet ...

[jsquyres]

Sadness.

Is anyone else asking for API notifications for this new Github feature? If not, can we ask about it somewhere?

[ggouaillardet]

I twitted https://mobile.twitter.com/giIIes/status/708320965126524929
it seems this is how they want feedback...

[ggouaillardet]

test