-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filegithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegoPull requests that update Go codePull requests that update Go code
Milestone
Description
Follow up to #44, it appears that 4842e47 added the RestartOnSecretRefresh, which restarts the process (os.Exit(0)
) every time refreshCerts()
is called, to update the Secret
.
That said, Kubernetes typically takes ~up to 1 minute delivering the secret to kubelet (easily reproducible on minikube, or kind, or a GKE cluster) with default kubelet configurations.
Since the delivery of updated Secret
to the Pod is not instant (or even a duration that can be considered quick), what makes the os.Exit(0)
useful if the kubelet will still serve the old Secret upon the restart?
cc: @stijndehaes
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filegithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegoPull requests that update Go codePull requests that update Go code