Skip to content

Conversation

@sozercan
Copy link
Member

@sozercan sozercan commented Apr 8, 2024

adds a new driver for an llm policy engine

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 204 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (76869f8) to head (7433cba).
Report is 6 commits behind head on master.

Files Patch % Lines
constraint/pkg/client/drivers/llm/driver.go 0.00% 160 Missing ⚠️
constraint/pkg/client/drivers/llm/schema/schema.go 0.00% 35 Missing ⚠️
constraint/pkg/client/drivers/llm/new.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   54.68%   51.44%   -3.24%     
==========================================
  Files          71      107      +36     
  Lines        5241     6735    +1494     
==========================================
+ Hits         2866     3465     +599     
- Misses       2073     2908     +835     
- Partials      302      362      +60     
Flag Coverage Δ
unittests 51.44% <0.00%> (-3.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sozercan and others added 2 commits April 8, 2024 21:02
@sozercan sozercan requested a review from maxsmythe April 11, 2024 01:14
if err != nil {
return err
}
if prompt == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than empty string, are there other prompts that we may want to prevent? could any prompts be used to exploit or manipulate the system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants