Skip to content

Commit 95d423e

Browse files
authored
Merge pull request #173 from open-runtimes/fix-spelling
Fix: spelling of threshold env var (breaking)
2 parents fa02050 + cef57d2 commit 95d423e

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ OPR_EXECUTOR_ENV=development
22
OPR_EXECUTOR_IMAGE_PULL=enabled
33
OPR_EXECUTOR_RUNTIMES=php-8.1,dart-2.18,deno-1.24,node-18.0,python-3.10,ruby-3.1,cpp-17,dotnet-6.0
44
OPR_EXECUTOR_CONNECTION_STORAGE=
5-
OPR_EXECUTOR_INACTIVE_TRESHOLD=60
5+
OPR_EXECUTOR_INACTIVE_THRESHOLD=60
66
OPR_EXECUTOR_MAINTENANCE_INTERVAL=60
77
OPR_EXECUTOR_NETWORK=executor_runtimes
88
OPR_EXECUTOR_IMAGE=executor-local

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ services:
5151
- OPR_EXECUTOR_ENV
5252
- OPR_EXECUTOR_RUNTIMES
5353
- OPR_EXECUTOR_CONNECTION_STORAGE
54-
- OPR_EXECUTOR_INACTIVE_TRESHOLD
54+
- OPR_EXECUTOR_INACTIVE_THRESHOLD
5555
- OPR_EXECUTOR_MAINTENANCE_INTERVAL
5656
- OPR_EXECUTOR_NETWORK
5757
- OPR_EXECUTOR_SECRET
@@ -82,7 +82,7 @@ OPR_EXECUTOR_ENV=development
8282
OPR_EXECUTOR_RUNTIMES=php-8.0
8383
OPR_EXECUTOR_CONNECTION_STORAGE=file://localhost
8484
OPR_EXECUTOR_IMAGE_PULL=enabled
85-
OPR_EXECUTOR_INACTIVE_TRESHOLD=60
85+
OPR_EXECUTOR_INACTIVE_THRESHOLD=60
8686
OPR_EXECUTOR_MAINTENANCE_INTERVAL=60
8787
OPR_EXECUTOR_NETWORK=openruntimes-runtimes
8888
OPR_EXECUTOR_SECRET=executor-secret-key
@@ -194,7 +194,7 @@ docker compose down
194194
| OPR_EXECUTOR_ENV | Environment mode of the executor, ex. `development` |
195195
| OPR_EXECUTOR_RUNTIMES | Comma-separated list of supported runtimes `(ex: php-8.1,dart-2.18,deno-1.24,..)`. These runtimes should be available as container images. |
196196
| OPR_EXECUTOR_CONNECTION_STORAGE | DSN string that represents a connection to your storage device, ex: `file://localhost` for local storage |
197-
| OPR_EXECUTOR_INACTIVE_TRESHOLD | Threshold time (in seconds) for detecting inactive runtimes, ex: `60` |
197+
| OPR_EXECUTOR_INACTIVE_THRESHOLD | Threshold time (in seconds) for detecting inactive runtimes, ex: `60` |
198198
| OPR_EXECUTOR_MAINTENANCE_INTERVAL| Interval (in seconds) at which the Executor performs maintenance tasks, ex: `60` |
199199
| OPR_EXECUTOR_NETWORK | Network used by the executor for runtimes, ex: `openruntimes-runtimes` |
200200
| OPR_EXECUTOR_SECRET | Secret key used by the executor for authentication |

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ services:
3636
- OPR_EXECUTOR_ENV
3737
- OPR_EXECUTOR_RUNTIMES
3838
- OPR_EXECUTOR_CONNECTION_STORAGE
39-
- OPR_EXECUTOR_INACTIVE_TRESHOLD
39+
- OPR_EXECUTOR_INACTIVE_THRESHOLD
4040
- OPR_EXECUTOR_MAINTENANCE_INTERVAL
4141
- OPR_EXECUTOR_NETWORK
4242
- OPR_EXECUTOR_SECRET

src/Executor/Runner/Docker.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private function init(array $networks): void
119119
Console::info("Running maintenance task ...");
120120
// Stop idling runtimes
121121
foreach ($this->activeRuntimes as $runtimeName => $runtime) {
122-
$inactiveThreshold = \time() - \intval(Http::getEnv('OPR_EXECUTOR_INACTIVE_TRESHOLD', '60'));
122+
$inactiveThreshold = \time() - \intval(Http::getEnv('OPR_EXECUTOR_INACTIVE_THRESHOLD', '60'));
123123
if ($runtime['updated'] < $inactiveThreshold) {
124124
go(function () use ($runtimeName, $runtime) {
125125
try {

0 commit comments

Comments
 (0)