Merge pull request #70 from open-runtimes/update-error-code

eldadfux · web-flow · commit faa9d9176aa6 · 2024-05-03T17:58:35.000+01:00
Update status code to 409 in createRuntime endpoint
diff --git a/app/http.php b/app/http.php
@@ -398,7 +398,7 @@ function removeAllRuntimes(Table $activeRuntimes, Orchestration $orchestration):
 
         if ($activeRuntimes->exists($runtimeName)) {
             if ($activeRuntimes->get($runtimeName)['status'] == 'pending') {
-                throw new \Exception('A runtime with the same ID is already being created. Attempt a execution soon.', 500);
+                throw new \Exception('A runtime with the same ID is already being created. Attempt a execution soon.', 409);
             }
 
             throw new Exception('Runtime already exists.', 409);

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ function removeAllRuntimes(Table $activeRuntimes, Orchestration $orchestration):`
`398`	`398`
`399`	`399`	`if ($activeRuntimes->exists($runtimeName)) {`
`400`	`400`	`if ($activeRuntimes->get($runtimeName)['status'] == 'pending') {`
`401`		`- throw new \Exception('A runtime with the same ID is already being created. Attempt a execution soon.', 500);`
	`401`	`+ throw new \Exception('A runtime with the same ID is already being created. Attempt a execution soon.', 409);`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`throw new Exception('Runtime already exists.', 409);`