Set aws.vpc.flow.start timestamp field to ISO8601 format #43390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
reviewed
Oct 9, 2025
Co-authored-by: Moritz Wiesinger <[email protected]>
|
@MichaelKatsoulis given that this has been out in the wild for a little while, I think we should put this change behind a featuregate |
…com:MichaelKatsoulis/opentelemetry-collector-contrib into chore/set-timestamp-field-to-iso8601-format
|
@axw I created a feature gate |
constanca-m
approved these changes
Oct 10, 2025
…com:MichaelKatsoulis/opentelemetry-collector-contrib into chore/set-timestamp-field-to-iso8601-format
bogdan-st
approved these changes
Oct 10, 2025
constanca-m
suggested changes
Oct 13, 2025
constanca-m
approved these changes
Oct 13, 2025
axw
added
the
ready to merge
mx-psi
approved these changes
Oct 14, 2025
|
Thank you for your contribution @MichaelKatsoulis! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
aws.vpc.flow.startfield type and value format for better standards compliance.Current State:
aws.vpc.flow.start(integer)1609459200)Problem:
The field represents the start timestamp of a VPC flow log entry. AWS provides this value as seconds since epoch, but OpenTelemetry semantic conventions don't currently define timestamp fields using this format. The majority of timestamp fields in semconv use either ISO-8601 string format or nanoseconds since epoch.
Solution:
This PR converts the field to:
aws.vpc.flow.start(string)"2021-01-01T00:00:00.000Z")Benefits:
Example:
aws.vpc.flow.start: 1609459200(int64)aws.vpc.flow.start: "2021-01-01T00:00:00.000Z"(string)Related Issue