Skip to content

Commit 8f46e78

Browse files
use a factory option to set telemetry attributes
1 parent 5abb4fb commit 8f46e78

File tree

53 files changed

+174
-295
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+174
-295
lines changed

.github/workflows/utils/cspell.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,6 @@
446446
"tailsampling",
447447
"tchannel",
448448
"telemetrygen",
449-
"telemetryimpl",
450449
"testcomponents",
451450
"testconverter",
452451
"testdata",

cmd/builder/internal/builder/main_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ var replaceModules = []string{
9292
"/internal/fanoutconsumer",
9393
"/internal/sharedcomponent",
9494
"/internal/telemetry",
95-
"/internal/telemetryimpl",
9695
"/otelcol",
9796
"/pdata",
9897
"/pdata/testdata",

cmd/mdatagen/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,5 +201,3 @@ replace go.opentelemetry.io/collector/extension/extensioncapabilities => ../../e
201201
replace go.opentelemetry.io/collector/pdata/xpdata => ../../pdata/xpdata
202202

203203
replace go.opentelemetry.io/collector/exporter/exporterhelper => ../../exporter/exporterhelper
204-
205-
replace go.opentelemetry.io/collector/internal/telemetryimpl => ../../internal/telemetryimpl

cmd/otelcorecol/builder-config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ replaces:
9292
- go.opentelemetry.io/collector/internal/memorylimiter => ../../internal/memorylimiter
9393
- go.opentelemetry.io/collector/internal/fanoutconsumer => ../../internal/fanoutconsumer
9494
- go.opentelemetry.io/collector/internal/telemetry => ../../internal/telemetry
95-
- go.opentelemetry.io/collector/internal/telemetryimpl => ../../internal/telemetryimpl
9695
- go.opentelemetry.io/collector/internal/sharedcomponent => ../../internal/sharedcomponent
9796
- go.opentelemetry.io/collector/otelcol => ../../otelcol
9897
- go.opentelemetry.io/collector/pdata => ../../pdata

cmd/otelcorecol/go.mod

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ require (
120120
go.opentelemetry.io/collector/internal/memorylimiter v0.135.0 // indirect
121121
go.opentelemetry.io/collector/internal/sharedcomponent v0.135.0 // indirect
122122
go.opentelemetry.io/collector/internal/telemetry v0.135.0 // indirect
123-
go.opentelemetry.io/collector/internal/telemetryimpl v0.135.0 // indirect
124123
go.opentelemetry.io/collector/pdata v1.41.0 // indirect
125124
go.opentelemetry.io/collector/pdata/pprofile v0.135.0 // indirect
126125
go.opentelemetry.io/collector/pdata/testdata v0.135.0 // indirect
@@ -288,8 +287,6 @@ replace go.opentelemetry.io/collector/internal/fanoutconsumer => ../../internal/
288287

289288
replace go.opentelemetry.io/collector/internal/telemetry => ../../internal/telemetry
290289

291-
replace go.opentelemetry.io/collector/internal/telemetryimpl => ../../internal/telemetryimpl
292-
293290
replace go.opentelemetry.io/collector/internal/sharedcomponent => ../../internal/sharedcomponent
294291

295292
replace go.opentelemetry.io/collector/otelcol => ../../otelcol

connector/xconnector/connector.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ package xconnector // import "go.opentelemetry.io/collector/connector/xconnector
55

66
import (
77
"context"
8+
"go.opentelemetry.io/otel/attribute"
89

910
"go.opentelemetry.io/collector/component"
1011
"go.opentelemetry.io/collector/connector"
@@ -213,6 +214,13 @@ func WithProfilesToLogs(createProfilesToLogs CreateProfilesToLogsFunc, sl compon
213214
})
214215
}
215216

217+
// WithTelemetryAttributes overrides the default component attributes setter to change the attributes to set on the component telemetry.
218+
func WithTelemetryAttributes(attributesFunc func(set attribute.Set) attribute.Set) FactoryOption {
219+
return factoryOptionFunc(func(o *factoryOpts) {
220+
o.attributesFunc = attributesFunc
221+
})
222+
}
223+
216224
// factory implements the Factory interface.
217225
type factory struct {
218226
connector.Factory
@@ -234,6 +242,8 @@ type factory struct {
234242
profilesToTracesStabilityLevel component.StabilityLevel
235243
profilesToMetricsStabilityLevel component.StabilityLevel
236244
profilesToLogsStabilityLevel component.StabilityLevel
245+
246+
attributesFunc func(set attribute.Set) attribute.Set
237247
}
238248

239249
func (f *factory) TracesToProfilesStability() component.StabilityLevel {
@@ -313,6 +323,13 @@ func (f *factory) CreateProfilesToLogs(ctx context.Context, set connector.Settin
313323
return f.createProfilesToLogsFunc(ctx, set, cfg, next)
314324
}
315325

326+
func (f *factory) TelemetryAttributes(attributes attribute.Set) attribute.Set {
327+
if f.attributesFunc != nil {
328+
return f.attributesFunc(attributes)
329+
}
330+
return attributes
331+
}
332+
316333
// NewFactory returns a Factory.
317334
func NewFactory(cfgType component.Type, createDefaultConfig component.CreateDefaultConfigFunc, options ...FactoryOption) Factory {
318335
opts := factoryOpts{factory: &factory{}}

connector/xconnector/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ require (
1414
go.opentelemetry.io/collector/pdata/testdata v0.135.0
1515
go.opentelemetry.io/collector/pipeline v1.41.0
1616
go.opentelemetry.io/collector/pipeline/xpipeline v0.135.0
17+
go.opentelemetry.io/otel v1.38.0
1718
)
1819

1920
require (
@@ -27,7 +28,6 @@ require (
2728
go.opentelemetry.io/collector/featuregate v1.41.0 // indirect
2829
go.opentelemetry.io/collector/internal/telemetry v0.135.0 // indirect
2930
go.opentelemetry.io/collector/pdata v1.41.0 // indirect
30-
go.opentelemetry.io/otel v1.38.0 // indirect
3131
go.opentelemetry.io/otel/metric v1.38.0 // indirect
3232
go.opentelemetry.io/otel/trace v1.38.0 // indirect
3333
go.uber.org/multierr v1.11.0 // indirect

internal/e2e/go.mod

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ require (
117117
go.opentelemetry.io/collector/featuregate v1.41.0 // indirect
118118
go.opentelemetry.io/collector/internal/fanoutconsumer v0.135.0 // indirect
119119
go.opentelemetry.io/collector/internal/telemetry v0.135.0 // indirect
120-
go.opentelemetry.io/collector/internal/telemetryimpl v0.135.0 // indirect
121120
go.opentelemetry.io/collector/pdata/pprofile v0.135.0 // indirect
122121
go.opentelemetry.io/collector/pdata/xpdata v0.135.0 // indirect
123122
go.opentelemetry.io/collector/pipeline/xpipeline v0.135.0 // indirect
@@ -270,8 +269,6 @@ replace go.opentelemetry.io/collector/internal/sharedcomponent => ../../internal
270269

271270
replace go.opentelemetry.io/collector/internal/telemetry => ../../internal/telemetry
272271

273-
replace go.opentelemetry.io/collector/internal/telemetryimpl => ../../internal/telemetryimpl
274-
275272
replace go.opentelemetry.io/collector/extension/extensiontest => ../../extension/extensiontest
276273

277274
replace go.opentelemetry.io/collector/extension/extensionauth/extensionauthtest => ../../extension/extensionauth/extensionauthtest

internal/telemetryimpl/Makefile

Lines changed: 0 additions & 1 deletion
This file was deleted.

internal/telemetryimpl/go.mod

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)