Skip to content

Commit d129d42

Browse files
authored
Make Context::HasKey const (#671)
- Update `Context::HasKey` to be const - Add const qualifier to HasKey,GetValue to validate constness
1 parent 9a99b97 commit d129d42

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

api/include/opentelemetry/context/context.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class Context
7676
}
7777

7878
// Checks for key and returns true if found
79-
bool HasKey(const nostd::string_view key) noexcept
79+
bool HasKey(const nostd::string_view key) const noexcept
8080
{
8181
for (DataList *data = head_.get(); data != nullptr; data = data->next_.get())
8282
{

api/test/context/context_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ TEST(ContextTest, ContextGetValueReturnsExpectedValue)
1818
{
1919
std::map<std::string, context::ContextValue> map_test = {{"test_key", (int64_t)123},
2020
{"foo_key", (int64_t)456}};
21-
context::Context test_context = context::Context(map_test);
21+
const context::Context test_context = context::Context(map_test);
2222
EXPECT_EQ(nostd::get<int64_t>(test_context.GetValue("test_key")), 123);
2323
EXPECT_EQ(nostd::get<int64_t>(test_context.GetValue("foo_key")), 456);
2424
}
@@ -119,7 +119,7 @@ TEST(ContextTest, ContextEmptyMap)
119119
TEST(ContextTest, ContextHasKey)
120120
{
121121
std::map<std::string, context::ContextValue> map_test = {{"test_key", (int64_t)123}};
122-
context::Context context_test = context::Context(map_test);
122+
const context::Context context_test = context::Context(map_test);
123123
EXPECT_TRUE(context_test.HasKey("test_key"));
124124
EXPECT_FALSE(context_test.HasKey("foo_key"));
125125
}

0 commit comments

Comments
 (0)