[Infra] Fix broken test

Fix test broken by change in behaviour in .NET 10.

Author: martincostello

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/README.net10.0.md

@@ -455,7 +455,7 @@
   "IdealHttpRoute": "/Index",
   "ActivityDisplayName": "GET",
   "ActivityHttpRoute": "",
-  "MetricHttpRoute": "",
+  "MetricHttpRoute": "/",
   "RouteInfo": {
     "HttpMethod": "GET",
     "Path": "/",

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTestCases.cs

@@ -27,10 +27,12 @@ public static IEnumerable<object[]> GetTestCases()
     private static List<object[]> GetArgumentsFromTestCaseObject(IEnumerable<TestCase> input)
     {
         var result = new List<object[]>();
+        var dotnetVersion = Environment.Version.Major;
 
         foreach (var testCase in input)
         {
-            if (testCase.MinimumDotnetVersion.HasValue && Environment.Version.Major < testCase.MinimumDotnetVersion.Value)
+            if ((testCase.MinimumDotnetVersion.HasValue && dotnetVersion < testCase.MinimumDotnetVersion.Value) ||
+                (testCase.MaximumDotnetVersion.HasValue && dotnetVersion > testCase.MaximumDotnetVersion.Value))
             {
                 continue;
             }

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTestCases.json

@@ -128,12 +128,24 @@
   {
     "name": "Root path",
     "testApplicationScenario": "RazorPages",
+    "maximumDotnetVersion": 9,
     "httpMethod": "GET",
     "path": "/",
     "expectedStatusCode": 200,
     "currentHttpRoute": "",
     "expectedHttpRoute": "/Index"
   },
+  {
+    "name": "Root path",
+    "testApplicationScenario": "RazorPages",
+    "minimumDotnetVersion": 10,
+    "httpMethod": "GET",
+    "path": "/",
+    "expectedStatusCode": 200,
+    "currentHttpRoute": "",
+    "expectedHttpRoute": "/Index",
+    "expectedMetricRoute": "/"
+  },
   {
     "name": "Index page",
     "testApplicationScenario": "RazorPages",

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTests.cs

@@ -74,11 +74,13 @@ public async Task TestHttpRoute(TestCase testCase)
         Assert.Equal(testCase.HttpMethod, activityHttpMethod);
         Assert.Equal(testCase.HttpMethod, metricHttpMethod);
 
-        // TODO: The CurrentHttpRoute property will go away. It They only serve to capture status quo.
+        // TODO: The CurrentHttpRoute property will go away. They only serve to capture status quo.
         // If CurrentHttpRoute is null, then that means we already conform to the correct behavior.
         var expectedHttpRoute = testCase.CurrentHttpRoute ?? testCase.ExpectedHttpRoute;
         Assert.Equal(expectedHttpRoute, activityHttpRoute);
-        Assert.Equal(expectedHttpRoute, metricHttpRoute);
+
+        var expectedMetricRoute = testCase.ExpectedMetricRoute ?? expectedHttpRoute;
+        Assert.Equal(expectedMetricRoute, metricHttpRoute);
 
         // Activity.DisplayName should be a combination of http.method + http.route attributes, see:
         // https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#name

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/TestCase.cs

@@ -11,6 +11,8 @@ public class TestCase
 
     public int? MinimumDotnetVersion { get; set; }
 
+    public int? MaximumDotnetVersion { get; set; }
+
     public TestApplicationScenario TestApplicationScenario { get; set; }
 
     public string? HttpMethod { get; set; }
@@ -23,6 +25,8 @@ public class TestCase
 
     public string? CurrentHttpRoute { get; set; }
 
+    public string? ExpectedMetricRoute { get; set; }
+
     public override string ToString()
     {
         // This is used by Visual Studio's test runner to identify the test case.