[Infra] Review skipped tests (#3177)

Author: martincostello

test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs

@@ -49,7 +49,7 @@ public UnixUserEventsDataTransportTests(ITestOutputHelper testOutputHelper)
         this.testOutputHelper = testOutputHelper;
     }
 
-    [Fact(Skip = "This would fail on Ubuntu. Skipping for now. See issue: #2326.")]
+    [SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true, Skip = "https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/2326")]
     public void UserEvents_Enabled_Success_Linux()
     {
         EnsureUserEventsEnabled();
@@ -78,9 +78,7 @@ public void UserEvents_Enabled_Success_Linux()
                 this.testOutputHelper.WriteLine(string.Join(", ", e.Select(kvp => $"{kvp.Key}={kvp.Value}")));
             }
 
-            Assert.Single(listener.Events);
-
-            var @event = listener.Events[0];
+            var @event = Assert.Single(listener.Events);
 
             Assert.EndsWith($" ({MetricUnixUserEventsDataTransport.MetricsProtocol})", @event["protocol"]);
             Assert.Equal(MetricUnixUserEventsDataTransport.MetricsVersion, @event["version"]);
@@ -113,7 +111,7 @@ public void UserEvents_Enabled_Success_Linux()
         }
     }
 
-    [Fact(Skip = "This would fail on Ubuntu. Skipping for now. See issue: #2326.")]
+    [SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true, Skip = "https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/2326")]
     public void UserEvents_Disabled_Success_Linux()
     {
         EnsureUserEventsEnabled();
@@ -143,7 +141,7 @@ public void UserEvents_Disabled_Success_Linux()
         }
     }
 
-    [Fact(Skip = "This would fail on Ubuntu. Skipping for now. See issue: #2326.")]
+    [SkipUnlessPlatformMatchesFact(TestPlatform.Linux, requireElevatedProcess: true, Skip = "https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/2326")]
     public void UserEvents_Logs_Success_Linux()
     {
         var listener = new PerfTracepointListener(

test/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests/ActivityHelperTest.cs

@@ -83,7 +83,7 @@ public async Task Can_Restore_Activity()
         await testTask;
     }
 
-    [Fact(Skip = "Temporarily disable until stable.")]
+    [Fact(Skip = "https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/3302")]
     public async Task Can_Restore_Baggage()
     {
         this.EnableListener();
@@ -94,8 +94,9 @@ public async Task Can_Restore_Baggage()
         };
 
         var context = HttpContextHelper.GetFakeHttpContextBase(headers: requestHeaders);
-        using var rootActivity = ActivityHelper.StartAspNetActivity(new CompositeTextMapPropagator([new TraceContextPropagator(), new BaggagePropagator()]), context, null)!;
+        using var rootActivity = ActivityHelper.StartAspNetActivity(new CompositeTextMapPropagator([new TraceContextPropagator(), new BaggagePropagator()]), context, null);
 
+        Assert.NotNull(rootActivity);
         rootActivity.AddTag("k1", "v1");
         rootActivity.AddTag("k2", "v2");
 

test/OpenTelemetry.Instrumentation.EventCounters.Tests/EventCountersMetricsTests.cs

@@ -9,7 +9,7 @@ namespace OpenTelemetry.Instrumentation.EventCounters.Tests;
 
 public class EventCountersMetricsTests
 {
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void EventCounter()
     {
         // Arrange
@@ -35,7 +35,7 @@ public void EventCounter()
         Assert.Equal(1997.0202, GetActualValue(metric));
     }
 
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void IncrementingEventCounter()
     {
         // Arrange
@@ -63,7 +63,7 @@ public void IncrementingEventCounter()
         Assert.Equal(3, GetActualValue(metric));
     }
 
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void PollingCounter()
     {
         // Arrange
@@ -89,7 +89,7 @@ public void PollingCounter()
         Assert.Equal(10, GetActualValue(metric));
     }
 
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void IncrementingPollingCounter()
     {
         // Arrange
@@ -163,7 +163,7 @@ public void EventSourceNameShortening(string sourceName, string eventName, strin
         Assert.Equal(1, GetActualValue(metric));
     }
 
-    [Fact(Skip = "This test should properly validate no metrics are exported from event counters with invalid names (too long)")]
+    [Fact]
     public async Task InstrumentNameTooLong()
     {
         // Arrange

test/OpenTelemetry.PersistentStorage.FileSystem.Tests/FileBlobTests.cs

@@ -114,7 +114,7 @@ public void FileBlobTests_Delete()
         Assert.False(testFile.Exists);
     }
 
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void FileBlobTests_DeleteFailsAfterLeaseIsExpired()
     {
         var testDirectory = new DirectoryInfo(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()));
@@ -143,7 +143,7 @@ public void FileBlobTests_DeleteFailsAfterLeaseIsExpired()
         testDirectory.Delete(true);
     }
 
-    [Fact(Skip = "Unstable")]
+    [Fact]
     public void FileBlobTests_LeaseTimeIsUpdatedWhenLeasingAlreadyLeasedFile()
     {
         var testFile = new FileInfo(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()));

test/OpenTelemetry.Sampler.AWS.Tests/TestAWSXRayRemoteSampler.cs

@@ -49,7 +49,11 @@ public void TestSamplerWithDefaults()
         Assert.NotNull(xraySampler?.Client);
     }
 
-    [Fact(Skip = "Flaky test. Related issue: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/1219")]
+#if NETFRAMEWORK
+    [Fact(Skip = "https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/1219")]
+#else
+    [Fact]
+#endif
     public void TestSamplerUpdateAndSample()
     {
         // setup mock server

test/Shared/PlatformHelpers.cs

@@ -5,6 +5,7 @@
 #pragma warning disable SA1402 // File may only contain a single type
 
 using System.Runtime.InteropServices;
+using System.Security.Principal;
 using Xunit;
 
 namespace OpenTelemetry.Tests;
@@ -21,14 +22,25 @@ internal sealed class TestPlatformHelpers
 {
     public static bool IsProcessElevated(TestPlatform platform)
     {
-        if (platform != TestPlatform.Linux)
+        switch (platform)
         {
+            case TestPlatform.Linux:
+                var userId = SystemNativeUnix.GetEUid();
+                return userId == 0;
+
+            case TestPlatform.Windows:
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+                {
+                    using var identity = WindowsIdentity.GetCurrent();
+                    return new WindowsPrincipal(identity).IsInRole(WindowsBuiltInRole.Administrator);
+                }
+
+                return false;
+
             // TODO: Add support for this check on other platforms as needed.
-            throw new NotImplementedException();
+            default:
+                throw new NotSupportedException($"TestPlatform '{platform}' is not supported for elevation check.");
         }
-
-        var userId = SystemNativeUnix.GetEUid();
-        return userId == 0;
     }
 
     // From: https://github.com/dotnet/corefx/blob/v2.2.8/src/Common/src/Interop/Unix/System.Native/Interop.GetEUid.cs