Skip to content

Conversation

Kielek
Copy link
Member

@Kielek Kielek commented Oct 14, 2025

Fixes Scorecard -->
Dangerous-Workflow https://scorecard.dev/viewer/?uri=github.com/open-telemetry/opentelemetry-dotnet-contrib

Changes

In general, it is doing the same as previously, but it makes scorecard happy.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.95%. Comparing base (b9248b8) to head (8fddb02).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   69.93%   69.95%   +0.02%     
==========================================
  Files         440      440              
  Lines       16974    16974              
==========================================
+ Hits        11870    11874       +4     
+ Misses       5104     5100       -4     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 82.73% <ø> (ø)
unittests-Exporter.Geneva 53.33% <ø> (ø)
unittests-Exporter.InfluxDB 95.14% <ø> (ø)
unittests-Exporter.Instana 74.86% <ø> (ø)
unittests-Exporter.OneCollector 94.61% <ø> (ø)
unittests-Extensions 90.65% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 83.80% <ø> (ø)
unittests-Instrumentation.AspNet 77.24% <ø> (ø)
unittests-Instrumentation.AspNetCore 70.76% <ø> (ø)
unittests-Instrumentation.Cassandra 23.52% <ø> (ø)
unittests-Instrumentation.ConfluentKafka 14.10% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 80.80% <ø> (ø)
unittests-Instrumentation.EventCounters 76.36% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.42% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (ø)
unittests-Instrumentation.Hangfire 84.61% <ø> (ø)
unittests-Instrumentation.Http 74.18% <ø> (ø)
unittests-Instrumentation.Owin 88.62% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 78.76% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 34.54% <ø> (ø)
unittests-Instrumentation.SqlClient 87.29% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 71.80% <ø> (ø)
unittests-Instrumentation.Wcf 79.41% <ø> (-0.14%) ⬇️
unittests-OpAmp.Client 72.28% <ø> (+0.73%) ⬆️
unittests-PersistentStorage 65.88% <ø> (ø)
unittests-Resources.AWS 74.42% <ø> (ø)
unittests-Resources.Azure 85.31% <ø> (ø)
unittests-Resources.Container 67.34% <ø> (ø)
unittests-Resources.Gcp 71.42% <ø> (ø)
unittests-Resources.Host 71.85% <ø> (ø)
unittests-Resources.OperatingSystem 76.98% <ø> (ø)
unittests-Resources.Process 100.00% <ø> (ø)
unittests-Resources.ProcessRuntime 79.59% <ø> (ø)
unittests-Sampler.AWS 87.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek force-pushed the onecollector-dangerous-workflow branch from 24ed859 to ed81acd Compare October 17, 2025 04:49
@Kielek Kielek marked this pull request as ready for review October 17, 2025 04:55
@Kielek Kielek requested a review from a team as a code owner October 17, 2025 04:55
@Kielek
Copy link
Member Author

Kielek commented Oct 17, 2025

Tested also on my fork, check outing looks good. Dummy changes removed

@Kielek Kielek merged commit 882da84 into open-telemetry:main Oct 17, 2025
233 checks passed
@Kielek Kielek deleted the onecollector-dangerous-workflow branch October 17, 2025 08:33
@Kielek
Copy link
Member Author

Kielek commented Oct 17, 2025

Unfortunately, it didn't fix the issue. I have missunderstand the go-lang scanning code.
Will check what can be done with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants