Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Sep 10, 2025

Preparation for #3095 (comment)

Changes

[repo] Use System.Threading.Lock

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner September 10, 2025 09:04
@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf labels Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.83%. Comparing base (8452d88) to head (335f6be).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
- Coverage   70.12%   69.83%   -0.29%     
==========================================
  Files         416      426      +10     
  Lines       16444    16495      +51     
==========================================
- Hits        11531    11520      -11     
- Misses       4913     4975      +62     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 83.73% <ø> (ø)
unittests-Exporter.Geneva 53.33% <100.00%> (-0.45%) ⬇️
unittests-Exporter.InfluxDB 95.14% <ø> (ø)
unittests-Exporter.Instana 74.86% <ø> (ø)
unittests-Exporter.OneCollector 94.61% <100.00%> (ø)
unittests-Extensions 90.65% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 94.11% <ø> (ø)
unittests-Instrumentation.AWS 83.80% <100.00%> (ø)
unittests-Instrumentation.AspNet 74.93% <ø> (ø)
unittests-Instrumentation.AspNetCore 70.76% <ø> (ø)
unittests-Instrumentation.Cassandra 23.52% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.10% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 80.80% <ø> (ø)
unittests-Instrumentation.EventCounters 76.36% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.42% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (ø)
unittests-Instrumentation.Hangfire 84.61% <ø> (ø)
unittests-Instrumentation.Http 74.18% <ø> (ø)
unittests-Instrumentation.Owin 88.62% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 78.76% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 34.54% <ø> (ø)
unittests-Instrumentation.SqlClient 87.29% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 70.31% <ø> (ø)
unittests-Instrumentation.Wcf 78.95% <100.00%> (ø)
unittests-OpAmp.Client 74.22% <ø> (ø)
unittests-PersistentStorage 65.88% <ø> (ø)
unittests-Resources.AWS 74.42% <ø> (ø)
unittests-Resources.Azure 85.31% <ø> (ø)
unittests-Resources.Container 67.34% <ø> (ø)
unittests-Resources.Gcp 71.42% <ø> (ø)
unittests-Resources.Host 73.91% <ø> (ø)
unittests-Resources.OperatingSystem 76.98% <ø> (ø)
unittests-Resources.Process 100.00% <ø> (ø)
unittests-Resources.ProcessRuntime 79.59% <ø> (ø)
unittests-Sampler.AWS 88.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ry.Exporter.Geneva/Internal/TableNameSerializer.cs 98.90% <100.00%> (ø)
....Exporter.OneCollector/Internal/CallbackManager.cs 96.00% <100.00%> (ø)
...OpenTelemetry.Extensions.AWS/AWSXRayIdGenerator.cs 58.90% <100.00%> (ø)
...Wcf/Implementation/RequestTelemetryStateTracker.cs 95.52% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Martin Costello <[email protected]>
@Kielek Kielek merged commit efa16d9 into open-telemetry:main Sep 10, 2025
233 of 234 checks passed
@Kielek Kielek deleted the locking branch September 10, 2025 09:20
@Kielek Kielek mentioned this pull request Sep 10, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants