Skip to content

Commit 82248c4

Browse files
authored
Apply suggestions from code review
1 parent f4e568a commit 82248c4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ public void configure(Map<String, ?> configs) {
7070
Object telemetrySupplier = configs.get(CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER);
7171
if (telemetrySupplier == null) {
7272
// Fallback to GlobalOpenTelemetry if not configured
73-
// TODO: remove these config properties checks once declarative configuration is available
7473
this.telemetry =
7574
KafkaTelemetry.builder(GlobalOpenTelemetry.get())
75+
// TODO: remove now that programmatic configuration is available
7676
.setMessagingReceiveInstrumentationEnabled(
7777
ConfigPropertiesUtil.getBoolean(
7878
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled",

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingProducerInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ public void configure(Map<String, ?> configs) {
5555
Object telemetrySupplier = configs.get(CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER);
5656
if (telemetrySupplier == null) {
5757
// Fallback to GlobalOpenTelemetry if not configured
58-
// TODO: remove these config properties checks once declarative configuration is available
5958
this.telemetry =
6059
KafkaTelemetry.builder(GlobalOpenTelemetry.get())
60+
// TODO: remove now that programmatic configuration is available
6161
.setCapturedHeaders(
6262
ConfigPropertiesUtil.getList(
6363
"otel.instrumentation.messaging.experimental.capture-headers", emptyList()))

0 commit comments

Comments
 (0)