Skip to content

Commit a5ce50c

Browse files
Copilottrask
andcommitted
Replace Function<X, X> with UnaryOperator<X> in unstable modules
Co-authored-by: trask <[email protected]>
1 parent 5d6afd2 commit a5ce50c

File tree

12 files changed

+31
-31
lines changed

12 files changed

+31
-31
lines changed

instrumentation/cassandra/cassandra-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CompletionStageFunction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
package io.opentelemetry.javaagent.instrumentation.cassandra.v4_0;
77

88
import com.datastax.oss.driver.api.core.CqlSession;
9-
import java.util.function.Function;
9+
import java.util.function.UnaryOperator;
1010

11-
public class CompletionStageFunction implements Function<Object, Object> {
11+
public class CompletionStageFunction implements UnaryOperator<Object> {
1212

1313
@Override
1414
public Object apply(Object session) {

instrumentation/cassandra/cassandra-4.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_4/CompletionStageFunction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
package io.opentelemetry.javaagent.instrumentation.cassandra.v4_4;
77

88
import com.datastax.oss.driver.api.core.CqlSession;
9-
import java.util.function.Function;
9+
import java.util.function.UnaryOperator;
1010

11-
public class CompletionStageFunction implements Function<Object, Object> {
11+
public class CompletionStageFunction implements UnaryOperator<Object> {
1212

1313
@Override
1414
public Object apply(Object session) {

instrumentation/elasticsearch/elasticsearch-rest-7.0/library/src/main/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/RestClientWrapper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import java.lang.reflect.Constructor;
1515
import java.lang.reflect.Field;
1616
import java.util.List;
17-
import java.util.function.Function;
1817
import java.util.function.Supplier;
18+
import java.util.function.UnaryOperator;
1919
import net.bytebuddy.ByteBuddy;
2020
import net.bytebuddy.description.modifier.Visibility;
2121
import net.bytebuddy.dynamic.loading.ClassLoadingStrategy;
@@ -32,7 +32,7 @@ class RestClientWrapper {
3232
private static final Class<?> proxyClass = createProxyClass();
3333
private static final Field targetField = getTargetField(proxyClass);
3434
private static final Field instrumenterSupplierField = getInstrumenterSupplierField(proxyClass);
35-
private static final Function<RestClient, RestClient> proxyFactory = getProxyFactory(proxyClass);
35+
private static final UnaryOperator<RestClient> proxyFactory = getProxyFactory(proxyClass);
3636

3737
private static Class<?> createProxyClass() {
3838
return new ByteBuddy()
@@ -139,7 +139,7 @@ private static Instrumenter<ElasticsearchRestRequest, Response> getInstrumenter(
139139
return supplier != null ? supplier.get() : null;
140140
}
141141

142-
private static Function<RestClient, RestClient> getProxyFactory(Class<?> clazz) {
142+
private static UnaryOperator<RestClient> getProxyFactory(Class<?> clazz) {
143143
for (Constructor<?> constructor : clazz.getDeclaredConstructors()) {
144144
Class<?>[] parameterTypes = constructor.getParameterTypes();
145145
if (parameterTypes.length >= 3

instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/engine/UnitConverter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import java.util.HashMap;
99
import java.util.Map;
1010
import java.util.concurrent.TimeUnit;
11-
import java.util.function.Function;
11+
import java.util.function.UnaryOperator;
1212
import javax.annotation.Nullable;
1313

1414
/**
@@ -24,7 +24,7 @@ class UnitConverter {
2424
registerConversion("ns", "s", value -> value.doubleValue() / TimeUnit.SECONDS.toNanos(1));
2525
}
2626

27-
private final Function<Number, Number> convertingFunction;
27+
private final UnaryOperator<Number> convertingFunction;
2828

2929
/**
3030
* Get an instance of converter that is able to convert a value from a given source to a target
@@ -66,7 +66,7 @@ public static UnitConverter getInstance(@Nullable String sourceUnit, String targ
6666
*/
6767
// visible for testing
6868
static void registerConversion(
69-
String sourceUnit, String targetUnit, Function<Number, Number> convertingFunction) {
69+
String sourceUnit, String targetUnit, UnaryOperator<Number> convertingFunction) {
7070
if (sourceUnit.isEmpty()) {
7171
throw new IllegalArgumentException("Non empty sourceUnit must be provided");
7272
}
@@ -92,7 +92,7 @@ private static String buildConverterKey(String sourceUnit, String targetUnit) {
9292
*
9393
* @param convertingFunction an algorithm applied when converting value
9494
*/
95-
UnitConverter(Function<Number, Number> convertingFunction) {
95+
UnitConverter(UnaryOperator<Number> convertingFunction) {
9696
this.convertingFunction = convertingFunction;
9797
}
9898

instrumentation/opentelemetry-api/opentelemetry-api-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetryapi/context/InstrumentationApiContextBridging.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.lang.invoke.MethodType;
1313
import java.util.ArrayList;
1414
import java.util.List;
15-
import java.util.function.Function;
15+
import java.util.function.UnaryOperator;
1616
import javax.annotation.Nullable;
1717

1818
final class InstrumentationApiContextBridging {
@@ -199,13 +199,13 @@ final class InstrumentationApiContextBridging {
199199
}
200200
}
201201

202-
private static Function<Object, Object> httpRouteStateConvert(
202+
private static UnaryOperator<Object> httpRouteStateConvert(
203203
MethodHandle create,
204204
MethodHandle getMethod,
205205
MethodHandle getRoute,
206206
MethodHandle getUpdatedBySourceOrder,
207207
MethodHandle getSpan,
208-
Function<Object, Object> convertSpan) {
208+
UnaryOperator<Object> convertSpan) {
209209
return httpRouteHolder -> {
210210
try {
211211
String method = (String) getMethod.invoke(httpRouteHolder);

instrumentation/reactor/reactor-3.1/library/src/main/java/io/opentelemetry/instrumentation/reactor/v3_1/ContextPropagationOperator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import java.lang.invoke.MethodHandle;
3232
import java.lang.invoke.MethodHandles;
3333
import java.util.function.BiFunction;
34-
import java.util.function.Function;
34+
import java.util.function.UnaryOperator;
3535
import java.util.logging.Level;
3636
import java.util.logging.Logger;
3737
import javax.annotation.Nullable;
@@ -175,7 +175,7 @@ public void registerOnEachOperator() {
175175
}
176176
}
177177

178-
private static void registerScheduleHook(String key, Function<Runnable, Runnable> function) {
178+
private static void registerScheduleHook(String key, UnaryOperator<Runnable> function) {
179179
if (SCHEDULERS_HOOK_METHOD == null) {
180180
return;
181181
}
@@ -252,7 +252,7 @@ private static <T extends Throwable> T sneakyThrow(Throwable t) throws T {
252252
}
253253

254254
private static class StoreOpenTelemetryContext
255-
implements Function<reactor.util.context.Context, reactor.util.context.Context> {
255+
implements UnaryOperator<reactor.util.context.Context> {
256256

257257
private final Context tracingContext;
258258

instrumentation/resources/library/src/main/java/io/opentelemetry/instrumentation/resources/internal/MainJarPathFinder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
import java.nio.file.InvalidPathException;
1010
import java.nio.file.Path;
1111
import java.nio.file.Paths;
12-
import java.util.function.Function;
1312
import java.util.function.Predicate;
1413
import java.util.function.Supplier;
14+
import java.util.function.UnaryOperator;
1515
import javax.annotation.Nullable;
1616

1717
class MainJarPathFinder {
1818
private final Supplier<String[]> getProcessHandleArguments;
19-
private final Function<String, String> getSystemProperty;
19+
private final UnaryOperator<String> getSystemProperty;
2020
private final Predicate<Path> fileExists;
2121

2222
public MainJarPathFinder() {
@@ -26,7 +26,7 @@ public MainJarPathFinder() {
2626
// visible for tests
2727
MainJarPathFinder(
2828
Supplier<String[]> getProcessHandleArguments,
29-
Function<String, String> getSystemProperty,
29+
UnaryOperator<String> getSystemProperty,
3030
Predicate<Path> fileExists) {
3131
this.getProcessHandleArguments = getProcessHandleArguments;
3232
this.getSystemProperty = getSystemProperty;

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/instrumentation/TypeTransformer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package io.opentelemetry.javaagent.extension.instrumentation;
77

8-
import java.util.function.Function;
8+
import java.util.function.UnaryOperator;
99
import net.bytebuddy.agent.builder.AgentBuilder;
1010
import net.bytebuddy.asm.Advice;
1111
import net.bytebuddy.description.method.MethodDescription;
@@ -25,7 +25,7 @@ public interface TypeTransformer {
2525
*/
2626
default void applyAdviceToMethod(
2727
ElementMatcher<? super MethodDescription> methodMatcher, String adviceClassName) {
28-
applyAdviceToMethod(methodMatcher, Function.identity(), adviceClassName);
28+
applyAdviceToMethod(methodMatcher, UnaryOperator.identity(), adviceClassName);
2929
}
3030

3131
/**
@@ -34,7 +34,7 @@ default void applyAdviceToMethod(
3434
*/
3535
void applyAdviceToMethod(
3636
ElementMatcher<? super MethodDescription> methodMatcher,
37-
Function<Advice.WithCustomMapping, Advice.WithCustomMapping> mappingCustomizer,
37+
UnaryOperator<Advice.WithCustomMapping> mappingCustomizer,
3838
String adviceClassName);
3939

4040
/**

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/TypeTransformerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import io.opentelemetry.javaagent.tooling.Utils;
1010
import io.opentelemetry.javaagent.tooling.bytebuddy.ExceptionHandlers;
1111
import io.opentelemetry.javaagent.tooling.instrumentation.indy.ForceDynamicallyTypedAssignReturnedFactory;
12-
import java.util.function.Function;
12+
import java.util.function.UnaryOperator;
1313
import net.bytebuddy.agent.builder.AgentBuilder;
1414
import net.bytebuddy.asm.Advice;
1515
import net.bytebuddy.description.method.MethodDescription;
@@ -31,7 +31,7 @@ final class TypeTransformerImpl implements TypeTransformer {
3131
@Override
3232
public void applyAdviceToMethod(
3333
ElementMatcher<? super MethodDescription> methodMatcher,
34-
Function<Advice.WithCustomMapping, Advice.WithCustomMapping> mappingCustomizer,
34+
UnaryOperator<Advice.WithCustomMapping> mappingCustomizer,
3535
String adviceClassName) {
3636
agentBuilder =
3737
agentBuilder.transform(

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/indy/IndyTypeTransformerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.io.FileOutputStream;
1313
import java.io.IOException;
1414
import java.util.function.BiFunction;
15-
import java.util.function.Function;
15+
import java.util.function.UnaryOperator;
1616
import net.bytebuddy.agent.builder.AgentBuilder;
1717
import net.bytebuddy.asm.Advice;
1818
import net.bytebuddy.description.method.MethodDescription;
@@ -51,7 +51,7 @@ public IndyTypeTransformerImpl(
5151
@Override
5252
public void applyAdviceToMethod(
5353
ElementMatcher<? super MethodDescription> methodMatcher,
54-
Function<Advice.WithCustomMapping, Advice.WithCustomMapping> mappingCustomizer,
54+
UnaryOperator<Advice.WithCustomMapping> mappingCustomizer,
5555
String adviceClassName) {
5656
// default strategy used by AgentBuilder.Transformer.ForAdvice
5757
AgentBuilder.PoolStrategy poolStrategy = AgentBuilder.PoolStrategy.Default.FAST;

0 commit comments

Comments
 (0)