Skip to content

Commit e5ca107

Browse files
Copilottrask
andcommitted
Clean up unused code and use imports instead of FQCN
Co-authored-by: trask <[email protected]>
1 parent 5f6294b commit e5ca107

File tree

2 files changed

+3
-27
lines changed

2 files changed

+3
-27
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractInterceptorsTest.java

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static org.assertj.core.api.Assertions.assertThat;
99

1010
import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.KafkaClientBaseTest;
11+
import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.OpenTelemetrySupplier;
1112
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1213
import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
1314
import java.nio.charset.StandardCharsets;
@@ -28,44 +29,25 @@ abstract class AbstractInterceptorsTest extends KafkaClientBaseTest {
2829

2930
static final String greeting = "Hello Kafka!";
3031

31-
private static KafkaTelemetry kafkaTelemetry;
32-
33-
protected static KafkaTelemetry createKafkaTelemetry() {
34-
return KafkaTelemetry.builder(testing.getOpenTelemetry())
35-
.setCapturedHeaders(java.util.Collections.singletonList("Test-Message-Header"))
36-
.setMessagingReceiveInstrumentationEnabled(true)
37-
.build();
38-
}
39-
4032
@Override
4133
public Map<String, Object> producerProps() {
42-
if (kafkaTelemetry == null) {
43-
kafkaTelemetry = createKafkaTelemetry();
44-
}
4534
Map<String, Object> props = super.producerProps();
4635
props.put(
4736
ProducerConfig.INTERCEPTOR_CLASSES_CONFIG, TracingProducerInterceptor.class.getName());
4837
props.put(
4938
TracingProducerInterceptor.CONFIG_KEY_OPENTELEMETRY_SUPPLIER,
50-
new io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal
51-
.OpenTelemetrySupplier(
52-
testing.getOpenTelemetry()));
39+
new OpenTelemetrySupplier(testing.getOpenTelemetry()));
5340
return props;
5441
}
5542

5643
@Override
5744
public Map<String, Object> consumerProps() {
58-
if (kafkaTelemetry == null) {
59-
kafkaTelemetry = createKafkaTelemetry();
60-
}
6145
Map<String, Object> props = super.consumerProps();
6246
props.put(
6347
ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG, TracingConsumerInterceptor.class.getName());
6448
props.put(
6549
TracingConsumerInterceptor.CONFIG_KEY_OPENTELEMETRY_SUPPLIER,
66-
new io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal
67-
.OpenTelemetrySupplier(
68-
testing.getOpenTelemetry()));
50+
new OpenTelemetrySupplier(testing.getOpenTelemetry()));
6951
return props;
7052
}
7153

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsSuppressReceiveSpansTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@
2323

2424
class InterceptorsSuppressReceiveSpansTest extends AbstractInterceptorsTest {
2525

26-
protected static KafkaTelemetry createKafkaTelemetry() {
27-
return KafkaTelemetry.builder(testing.getOpenTelemetry())
28-
.setMessagingReceiveInstrumentationEnabled(false)
29-
.build();
30-
}
31-
3226
@SuppressWarnings("deprecation") // using deprecated semconv
3327
@Override
3428
void assertTraces() {

0 commit comments

Comments
 (0)