Rename ComposableTraceIdRatioBased to ComposableProbability (#7786)

Author: anuraaga

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableTraceIdRatioBasedSampler.java renamed to sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableProbabilitySampler.java

@@ -12,7 +12,7 @@
 import java.util.List;
 import java.util.function.Function;
 
-final class ComposableTraceIdRatioBasedSampler implements ComposableSampler {
+final class ComposableProbabilitySampler implements ComposableSampler {
   private static long calculateThreshold(double ratio) {
     return ImmutableSamplingIntent.MAX_THRESHOLD
         - Math.round(ratio * (double) ImmutableSamplingIntent.MAX_THRESHOLD);
@@ -21,7 +21,7 @@ private static long calculateThreshold(double ratio) {
   private final SamplingIntent intent;
   private final String description;
 
-  ComposableTraceIdRatioBasedSampler(double ratio) {
+  ComposableProbabilitySampler(double ratio) {
     long threshold = calculateThreshold(ratio);
     String thresholdStr;
     if (threshold == ImmutableSamplingIntent.MAX_THRESHOLD) {

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableSampler.java

@@ -24,8 +24,8 @@ static ComposableSampler alwaysOn() {
   }
 
   /** Returns a {@link ComposableSampler} that samples each span with a fixed ratio. */
-  static ComposableSampler traceIdRatioBased(double ratio) {
-    return new ComposableTraceIdRatioBasedSampler(ratio);
+  static ComposableSampler probability(double ratio) {
+    return new ComposableProbabilitySampler(ratio);
   }
 
   /**

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableTraceIdRatioBasedSamplerTest.java renamed to sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableProbabilitySamplerTest.java

@@ -21,21 +21,21 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
 
-class ComposableTraceIdRatioBasedSamplerTest {
+class ComposableProbabilitySamplerTest {
   @Test
   void testDescription() {
-    assertThat(ComposableSampler.traceIdRatioBased(1.0).getDescription())
+    assertThat(ComposableSampler.probability(1.0).getDescription())
         .isEqualTo("ComposableTraceIdRatioBasedSampler{threshold=0, ratio=1.0}");
-    assertThat(ComposableSampler.traceIdRatioBased(1.0))
+    assertThat(ComposableSampler.probability(1.0))
         .hasToString("ComposableTraceIdRatioBasedSampler{threshold=0, ratio=1.0}");
 
-    assertThat(ComposableSampler.traceIdRatioBased(0.5).getDescription())
+    assertThat(ComposableSampler.probability(0.5).getDescription())
         .isEqualTo("ComposableTraceIdRatioBasedSampler{threshold=8, ratio=0.5}");
-    assertThat(ComposableSampler.traceIdRatioBased(0.25).getDescription())
+    assertThat(ComposableSampler.probability(0.25).getDescription())
         .isEqualTo("ComposableTraceIdRatioBasedSampler{threshold=c, ratio=0.25}");
-    assertThat(ComposableSampler.traceIdRatioBased(1e-300).getDescription())
+    assertThat(ComposableSampler.probability(1e-300).getDescription())
         .isEqualTo("ComposableTraceIdRatioBasedSampler{threshold=max, ratio=1.0E-300}");
-    assertThat(ComposableSampler.traceIdRatioBased(0).getDescription())
+    assertThat(ComposableSampler.probability(0).getDescription())
         .isEqualTo("ComposableTraceIdRatioBasedSampler{threshold=max, ratio=0.0}");
   }
 
@@ -53,7 +53,7 @@ void testDescription() {
   })
   void sampling(double ratio, long threshold) {
     Supplier<String> generator = traceIdGenerator();
-    Sampler sampler = CompositeSampler.wrap(ComposableSampler.traceIdRatioBased(ratio));
+    Sampler sampler = CompositeSampler.wrap(ComposableSampler.probability(ratio));
     int numSampled = 0;
     for (int i = 0; i < 10000; i++) {
       SamplingResult result =

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/CompositeSamplerTest.java

@@ -189,7 +189,7 @@ void testMinThresholdWithParentRandomValue() {
   void testMaxThreshold() {
     Input input = new Input();
 
-    Sampler sampler = CompositeSampler.wrap(ComposableSampler.traceIdRatioBased(0.0));
+    Sampler sampler = CompositeSampler.wrap(ComposableSampler.probability(0.0));
 
     Output output = sample(input, sampler);
 
@@ -237,7 +237,7 @@ void testHalfThresholdNotSampled() {
     Input input = new Input();
     input.setParentRandomValue(0x7FFFFFFFFFFFFFL);
 
-    Sampler sampler = CompositeSampler.wrap(ComposableSampler.traceIdRatioBased(0.5));
+    Sampler sampler = CompositeSampler.wrap(ComposableSampler.probability(0.5));
 
     Output output = sample(input, sampler);
 
@@ -251,7 +251,7 @@ void testHalfThresholdSampled() {
     Input input = new Input();
     input.setParentRandomValue(0x80000000000000L);
 
-    Sampler sampler = CompositeSampler.wrap(ComposableSampler.traceIdRatioBased(0.5));
+    Sampler sampler = CompositeSampler.wrap(ComposableSampler.probability(0.5));
 
     Output output = sample(input, sampler);
 
@@ -268,7 +268,7 @@ void testParentViolatingInvariant() {
     input.setParentRandomValue(0x80000000000000L);
     input.setParentSampled(false);
 
-    Sampler sampler = CompositeSampler.wrap(ComposableSampler.traceIdRatioBased(1.0));
+    Sampler sampler = CompositeSampler.wrap(ComposableSampler.probability(1.0));
     Output output = sample(input, sampler);
 
     assertThat(output.samplingResult.getDecision()).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE);