ci(test): use environment variables over shell evaluation when reporting coverage (#3088)

Author: pichlermarc

.github/workflows/test.yml

@@ -277,5 +277,8 @@ jobs:
           name: tests-coverage-cache-${{ github.run_number }}-24
           path: .
       - name: Report Coverage with Flags
-        run: node ./scripts/codecov-upload-flags.mjs ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.head.label }}
+        run: node ./scripts/codecov-upload-flags.mjs
+        env:
+          COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
+          PR_BRANCH_NAME: ${{ github.event.pull_request.head.label }}
 

scripts/codecov-upload-flags.mjs

@@ -6,8 +6,8 @@ import path from 'path';
 // Usage
 // node ./scripts/codecov-upload-flags.mjs
 
-const commitSha = process.argv[2];
-const branchName = process.argv[3];
+const commitSha = process.env.COMMIT_SHA;
+const branchName = process.env.PR_BRANCH_NAME;
 
 const readPkg = (dir) => JSON.parse(readFileSync(path.join(dir, 'package.json'), 'utf8'));
 const pkgInfo = readPkg('.');