Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 26, 2024

Which problem is this PR solving?

Short description of the changes

@trivikr trivikr marked this pull request as ready for review November 26, 2024 16:04
@trivikr trivikr requested a review from a team as a code owner November 26, 2024 16:04
@trivikr
Copy link
Contributor Author

trivikr commented Nov 26, 2024

cc @pichlermarc who'd enabled workflow for previous PR.

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (2784357) to head (3705ed7).
Report is 184 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.04%     
==========================================
  Files         169      169              
  Lines        8018     8018              
  Branches     1632     1632              
==========================================
+ Hits         7277     7281       +4     
+ Misses        741      737       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm
Copy link
Contributor

trentm commented Nov 28, 2024

I'd like to propose an alternative so that we can get the examples/* being linted using mostly the same eslitn config as the rest of the repo uses (using the top-level "eslint.config.js"). I have a start at supporting this here:
#2567

@dyladan
Copy link
Member

dyladan commented Jun 25, 2025

@trivikr there is already a lint workflow that is doing everything except the examples. I would prefer to extend that rather than adding a separate workflow that doesn't use our config. Trent already is working on this

@dyladan dyladan closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants