Skip to content

Commit 7ab6aba

Browse files
authored
chore: fixing wrong return type for metric observer callback (#949)
1 parent 4a5717c commit 7ab6aba

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/opentelemetry-api/src/metrics/BoundInstrument.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ export interface BoundObserver {
5454
* retrieve the value.
5555
* @param callback
5656
*/
57-
setCallback(callback: (observerResult: ObserverResult) => {}): void;
57+
setCallback(callback: (observerResult: ObserverResult) => void): void;
5858
}

packages/opentelemetry-api/src/metrics/NoopMeter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export class NoopBoundMeasure implements BoundMeasure {
136136
}
137137

138138
export class NoopBoundObserver implements BoundObserver {
139-
setCallback(callback: (observerResult: ObserverResult) => {}): void {}
139+
setCallback(callback: (observerResult: ObserverResult) => void): void {}
140140
}
141141

142142
export const NOOP_METER = new NoopMeter();

packages/opentelemetry-metrics/src/BoundInstrument.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export class BoundObserver extends BaseBoundInstrument
147147
super(labels, logger, monotonic, disabled, valueType, aggregator);
148148
}
149149

150-
setCallback(callback: (observerResult: types.ObserverResult) => {}): void {
150+
setCallback(callback: (observerResult: types.ObserverResult) => void): void {
151151
const observerResult = new ObserverResult();
152152
callback(observerResult);
153153
}

0 commit comments

Comments
 (0)