Skip to content

Conversation

@Delapouite
Copy link
Contributor

Which problem is this PR solving?

Hi.

While skimming through the codebase in my IDE, I stumbled this identity function that has no reference. I've grepped the package to ensure this was indeed not used anymore and it's now dead code.

It was introduced in this commit but never actually used 595d0e9

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Delapouite Delapouite requested a review from a team as a code owner December 6, 2025 12:01
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (bc9e37f) to head (6dab271).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6195   +/-   ##
=======================================
  Coverage   95.40%   95.41%           
=======================================
  Files         317      317           
  Lines        9462     9460    -2     
  Branches     2199     2199           
=======================================
- Hits         9027     9026    -1     
+ Misses        435      434    -1     
Files with missing lines Coverage Δ
packages/opentelemetry-resources/src/utils.ts 100.00% <ø> (+14.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@pichlermarc pichlermarc added this pull request to the merge queue Dec 6, 2025
Merged via the queue into open-telemetry:main with commit efa7ef5 Dec 6, 2025
27 of 28 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Dec 6, 2025

Thank you for your contribution @Delapouite! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@Delapouite Delapouite deleted the fix/resources-identity branch December 6, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants