Skip to content

Commit e92b67a

Browse files
committed
cleanup test
1 parent 6c71646 commit e92b67a

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

util/opentelemetry-util-genai/tests/test_handler_metrics.py

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,6 @@ def test_fail_llm_records_error_and_available_tokens(self) -> None:
126126
)
127127
self.assertAlmostEqual(token_point.sum, 11.0, places=3)
128128

129-
@staticmethod
130-
def _get_span_start_time(span) -> int:
131-
for attr in ("start_time", "_start_time"):
132-
value = getattr(span, attr, None)
133-
if isinstance(value, int):
134-
return value
135-
raise AssertionError("Span start time not available")
136-
137129
def _harvest_metrics(self) -> Dict[str, List[Any]]:
138130
try:
139131
self.meter_provider.force_flush()
@@ -142,14 +134,9 @@ def _harvest_metrics(self) -> Dict[str, List[Any]]:
142134
self.metric_reader.collect()
143135
metrics_by_name: Dict[str, List[Any]] = {}
144136
data = self.metric_reader.get_metrics_data()
145-
for resource_metric in data.resource_metrics or []:
137+
for resource_metric in (data and data.resource_metrics) or []:
146138
for scope_metric in resource_metric.scope_metrics or []:
147-
for metric in getattr(scope_metric, "metrics", []) or []:
148-
points = list(
149-
getattr(metric.data, "data_points", []) or []
150-
)
151-
if points:
152-
metrics_by_name.setdefault(metric.name, []).extend(
153-
points
154-
)
139+
for metric in scope_metric.metrics or []:
140+
points = metric.data.data_points or []
141+
metrics_by_name.setdefault(metric.name, []).extend(points)
155142
return metrics_by_name

0 commit comments

Comments
 (0)