Prompting free user to either use a different account or upgrade #2472
Conversation
aibrahim-oai
requested review from
bolinfest,
dylan-hurd-oai,
easong-openai and
edward-bayes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request that is ready for review, or mark a draft as ready for review. You can also ask for a review by commenting "@codex review".
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| mod auth; | ||
| mod continue_to_chat; | ||
| mod free_plan_screen; | ||
| pub mod onboarding_screen; | ||
| mod trust_directory; |
There was a problem hiding this comment.
[P0] Remove unresolved free_plan_screen module
onboarding/mod.rs declares mod free_plan_screen; but no such file exists. Building codex-tui fails with E0583: file not found for module and the application cannot compile. Delete the declaration or add the module file.
Useful? React with 👍 / 👎.
| let login_status = get_login_status(&config); | ||
| tracing::info!("login_status1: {:?}", login_status); | ||
| let should_show_onboarding = |
There was a problem hiding this comment.
[P0] Avoid logging login status exposing API keys
App::new logs login_status at info level (tracing::info!). LoginStatus::Auth wraps CodexAuth whose Debug output includes the API key, so running the app prints credentials to logs/console. Sensitive secrets should not be logged.
Useful? React with 👍 / 👎.
|
@codex fix comments and the merge conflict. |
|
Summary
Testing
|
1 participant
Screen.Recording.2025-08-19.at.3.19.16.PM.mov
Caveat: If user's plan expired, we will still show the old error because we don't have access to the updated plan type. (which I think is fine because they may go renew it and continue the conversation)
Example: