-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Auto-approve DangerFullAccess patches on non-sandboxed platforms #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-approve DangerFullAccess patches on non-sandboxed platforms #2988
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
same problem, not fixed yet |
|
can someone approve this? It's making windows usage overly challenging |
|
Hi @bolinfest @nornagon-openai @pakrym-oai — friendly ping for a review/decision on this PR. Workflows are pending maintainer approval (so CI hasn’t run yet). The branch is up to date with main. If you’re not the right reviewers, could you please tag the right owner? Thanks! |
|
yes please, this issue quite challenging, the rest is great.. |
Prefer `if` in match guard instead of matches!().
|
Thanks for this! |
What?
Auto-approve patches when
SandboxPolicy::DangerFullAccessis enabled on platforms without sandbox support.Changes in
codex-rs/core/src/safety.rs: returnSafetyCheck::AutoApprove { sandbox_type: SandboxType::None }when no sandbox is available and DangerFullAccess is set.Why?
On platforms lacking sandbox support, requiring explicit user approval despite
DangerFullAccessbeing explicitly enabled adds friction without additional safety. This aligns behavior with the stated policy intent.How?
Extend
assess_patch_safetymatch:get_platform_sandbox()returnsSome, keepAutoApprove { sandbox_type }.NoneandSandboxPolicy::DangerFullAccess, returnAutoApprove { SandboxType::None }.AskUser.Tests
just fmt,just fix -p codex-core,cargo check -p codex-core.)Docs
No user-facing CLI changes. No README/help updates needed.
Risk/Impact
Reduces prompts on non-sandboxed platforms when DangerFullAccess is explicitly chosen; consistent with policy semantics.