Skip to content

Let user pick base branch during /review #4282

@sluongng

Description

@sluongng

What feature would you like to see?

I use a git fetch-rebase/reset workflow. Typically on a feature branch, I will run the following

git fetch origin
git rebase -i origin/master

what this means is that a lot of time, my remote-tracking origin/master branch is more up-to-date than my local master branch. For this reason, I often rebase on origin/master instead of master.

When codex runs /review after my feature branch is rebased onto origin/master, I am only given the option to diff against master, which is out-of-date. This means that the diff result would include changes between master..origin/master, which I don't want to include in the review.

Currently, the workaround is for me to also update the local master branch before running review

git checkout master
git reset --hard origin/master
git checkout -

I would prefer it if I could manually type in the exact ref/commit for /review to diff against.

Are you interested in implementing this feature?

Sure. I think we can run git for-each-ref instead of git branch to get the list of available refs. That way, other users may diff against release tags to get a pre-release review.

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions