Skip to content

Conversation

@terror
Copy link

@terror terror commented Nov 5, 2025

This PR honors the history.max_bytes configuration parameter by trimming history.jsonl whenever it grows past the configured limit. While appending new entries we retain the newest record, drop the oldest lines to stay within the byte budget, and serialize the compacted file back to disk under the same lock to keep writers safe.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@terror
Copy link
Author

terror commented Nov 5, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 5, 2025
@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai
Copy link
Collaborator

Thanks for the contributions. It looks like the newly-added tests are failing in CI. Could you take a look?

@etraut-openai etraut-openai added the needs-response Additional information is requested label Nov 5, 2025
@terror
Copy link
Author

terror commented Nov 5, 2025

Thanks for the contributions. It looks like the newly-added tests are failing in CI. Could you take a look?

I believe this was because we were missing a write(true) for truncation rights on Windows. My latest commit should fix this up.

@terror
Copy link
Author

terror commented Nov 5, 2025

Thanks for the contributions. It looks like the newly-added tests are failing in CI. Could you take a look?

I believe this was because we were missing a write(true) for truncation rights on Windows. My latest commit should fix this up.

Alright, so apparently on Windows adding append(true) strips the handle of FILE_WRITE_DATA, leaving only FILE_APPEND_DATA. I've gated the append(true) for unix only.

@bolinfest bolinfest self-requested a review November 7, 2025 15:47
@etraut-openai etraut-openai removed the needs-response Additional information is requested label Nov 9, 2025
youta7 added a commit to youta7/ta-codex that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants