core: add a feature to disable the shell tool #6481
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Default, | ||
| Local, | ||
| UnifiedExec, | ||
| Disabled, |
There was a problem hiding this comment.
Maybe include a flavor of the PR body as a docstring here (this is accurate, right?):
| Disabled, | |
| /// Do not include a shell tool by default. Useful when using Codex | |
| /// with tools provided exclusively provided by MCP servers. Often used | |
| /// with `--config base_instructions=CUSTOM_INSTRUCTIONS` | |
| /// to customize agent behavior. | |
| Disabled, |
| id: Feature::ShellTool, | ||
| key: "shell_tool", | ||
| stage: Stage::Stable, | ||
| default_enabled: true, |
There was a problem hiding this comment.
Should we flip the sense of this so this is default_enabled: false like everything else? Feature::UserProvidedShellTool or something like that?
There was a problem hiding this comment.
modeled this after view_image_tool above.
--disable shell_tooldisables the built-in shell tool. This is useful for MCP-only operation.