Skip to content

t_ringbuf.c: Suspicious useless variable j in upause() function #3

@liuqun

Description

@liuqun

// Simple busywait.
// usleep() is not granular enough
static void
upause(int n)
{
int i;
volatile uint64_t j = sys_cpu_timestamp();
for (i = 0; i < n; ++i) {
j += i;
rte_pause();
}
}

Maybe simply asm("nop") is better:

     for (i = 0; i < n; ++i) { 
         asm("nop");
         rte_pause(); 
     } 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions