This repository was archived by the owner on Oct 21, 2025. It is now read-only.
build: Remove reactifex dependency. #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
feanil
force-pushed
the
feanil/remove-reactifex-packages
branch
from
9264395 to
40eb5c0
Compare
This repo only relies on that deprecated library for one script and since this repo is also on the road to deprecation, for now I've just copied the one script we needed from that repo to here so that we can drop that dependency and archive that repo.
feanil
force-pushed
the
feanil/remove-reactifex-packages
branch
from
40eb5c0 to
8bdaf3d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 75 75
Lines 1711 1711
Branches 412 416 +4
=======================================
Hits 1697 1697
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
reviewed
Sep 26, 2025
| i18n = ./src/i18n | ||
| transifex_input = $(i18n)/transifex_input.json | ||
| transifex_utils = ./node_modules/.bin/edx_reactifex | ||
| transifex_utils = node ./scripts/concat_translations.js |
Contributor
There was a problem hiding this comment.
This doesn't look like a regular transifex_utils definition. Any particular reason why?
brian-smith-tcril
approved these changes
Sep 26, 2025
Contributor
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
LGTM!
I'm on board with the "just copy the script we need in for now" solution, and I assume you've verified that the transifex_input.json file this generates with these changes matches the pre-change version.
Contributor
Author
|
Yep, the output is the same from my testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo only relies on that deprecated library for one script and
since this repo is also on the road to deprecation, for now I've just
copied the one script we needed from that repo to here so that we can
drop that dependency and archive that repo.