Skip to content

Commit 2e37562

Browse files
authored
Refactor: Remove unused GetUsersInfoWithCache function (#707)
* refactor: fix error handling in SendMessage function * Refactor: Remove unused GetUsersInfoWithCache function * remove unused markfile contents.
1 parent ba04362 commit 2e37562

File tree

4 files changed

+0
-20
lines changed

4 files changed

+0
-20
lines changed

Makefile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -130,16 +130,6 @@ ifeq ($(origin GOBIN), undefined)
130130
GOBIN := $(GOPATH)/bin
131131
endif
132132

133-
COMMANDS ?= $(filter-out %.md, $(wildcard ${ROOT_DIR}/cmd/*))
134-
BINS ?= $(foreach cmd,${COMMANDS},$(notdir ${cmd}))
135-
136-
ifeq (${COMMANDS},)
137-
$(error Could not determine COMMANDS, set ROOT_DIR or run in source dir)
138-
endif
139-
ifeq (${BINS},)
140-
$(error Could not determine BINS, set ROOT_DIR or run in source dir)
141-
endif
142-
143133
EXCLUDE_TESTS=github.com/openimsdk/openim-sdk-core/test
144134

145135
# ==============================================================================

open_im_sdk/user.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,3 @@ func GetAllUserCommands(callback open_im_sdk_callback.Base, operationID string,
5252
call(callback, operationID, UserForSDK.User().ProcessUserCommandGetAll, Type)
5353
}
5454

55-
// GetUsersInfoWithCache gets the user's information with cache.
56-
func GetUsersInfoWithCache(callback open_im_sdk_callback.Base, operationID string, userIDs string) {
57-
call(callback, operationID, UserForSDK.User().GetUsersInfoWithCache, userIDs)
58-
}

wasm/cmd/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ func registerFunc() {
159159
js.Global().Set("setSelfInfo", js.FuncOf(wrapperUser.SetSelfInfo))
160160
//js.Global().Set("setSelfInfoEx", js.FuncOf(wrapperUser.SetSelfInfo))
161161
js.Global().Set("getUsersInfo", js.FuncOf(wrapperUser.GetUsersInfo))
162-
js.Global().Set("getUsersInfoWithCache", js.FuncOf(wrapperUser.GetUsersInfoWithCache))
163162
js.Global().Set("subscribeUsersStatus", js.FuncOf(wrapperUser.SubscribeUsersStatus))
164163
js.Global().Set("unsubscribeUsersStatus", js.FuncOf(wrapperUser.UnsubscribeUsersStatus))
165164
js.Global().Set("getSubscribeUsersStatus", js.FuncOf(wrapperUser.GetSubscribeUsersStatus))

wasm/wasm_wrapper/wasm_user.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,6 @@ func (w *WrapperUser) GetUsersInfo(_ js.Value, args []js.Value) interface{} {
4949
return event_listener.NewCaller(open_im_sdk.GetUsersInfo, callback, &args).AsyncCallWithCallback()
5050
}
5151

52-
func (w *WrapperUser) GetUsersInfoWithCache(_ js.Value, args []js.Value) interface{} {
53-
callback := event_listener.NewBaseCallback(utils.FirstLower(utils.GetSelfFuncName()), w.commonFunc)
54-
return event_listener.NewCaller(open_im_sdk.GetUsersInfoWithCache, callback, &args).AsyncCallWithCallback()
55-
}
56-
5752
func (w *WrapperUser) SubscribeUsersStatus(_ js.Value, args []js.Value) interface{} {
5853
callback := event_listener.NewBaseCallback(utils.FirstLower(utils.GetSelfFuncName()), w.commonFunc)
5954
return event_listener.NewCaller(open_im_sdk.SubscribeUsersStatus, callback, &args).AsyncCallWithCallback()

0 commit comments

Comments
 (0)