-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371753: compiler/c2/cr7200264/TestIntVect.java fails IR verification #28279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
|
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@RealFYang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
chhagedorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
feilongjiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@chhagedorn @feilongjiang : Thanks for the review! |
|
Going to push as commit eaddefb.
Your commit was automatically rebased without conflicts. |
|
@RealFYang Pushed as commit eaddefb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, please consider this test-only change fixing an IR test failure.
This test fails after https://bugs.openjdk.org/browse/JDK-8340093 which enabled IR matching for three vector nodes.
That relies on support for vector operations and will fail on platforms without that. This adds the necessary conditions
for applying this matching rule. This enables more IR matching in this test for RISC-V vector as well.
Verified with fastdebug build on aarch64, x86_64 and riscv64 platforms.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28279/head:pull/28279$ git checkout pull/28279Update a local copy of the PR:
$ git checkout pull/28279$ git pull https://git.openjdk.org/jdk.git pull/28279/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28279View PR using the GUI difftool:
$ git pr show -t 28279Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28279.diff
Using Webrev
Link to Webrev Comment