Skip to content

Conversation

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 13, 2025

Hi, please consider this test-only change fixing an IR test failure.

This test fails after https://bugs.openjdk.org/browse/JDK-8340093 which enabled IR matching for three vector nodes.
That relies on support for vector operations and will fail on platforms without that. This adds the necessary conditions
for applying this matching rule. This enables more IR matching in this test for RISC-V vector as well.

Verified with fastdebug build on aarch64, x86_64 and riscv64 platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371753: compiler/c2/cr7200264/TestIntVect.java fails IR verification (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28279/head:pull/28279
$ git checkout pull/28279

Update a local copy of the PR:
$ git checkout pull/28279
$ git pull https://git.openjdk.org/jdk.git pull/28279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28279

View PR using the GUI difftool:
$ git pr show -t 28279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28279.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371753: compiler/c2/cr7200264/TestIntVect.java fails IR verification

Reviewed-by: chagedorn, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@RealFYang RealFYang marked this pull request as ready for review November 13, 2025 02:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2025
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RealFYang
Copy link
Member Author

@chhagedorn @feilongjiang : Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

Going to push as commit eaddefb.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2025
@openjdk openjdk bot closed this Nov 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@RealFYang Pushed as commit eaddefb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants