Flake8 integration for Linting #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xtanion <[email protected]>
Signed-off-by: xtanion <[email protected]>
Contributor
Author
|
Hi @pleia2, Sorry for messaging you this late. We should merge this PR first since we've decided to move forward with the Flake8 linting format. It'll add the GitHub workflow. Initially, I was planning to change everything in just one PR, but it'll be a hassle to review manually & if we've flake8 workflow already set up, I'll do half of the jobs for us (that is, checking the PR). Please let me know your thought on this. Thanks. |
Contributor
|
No decision has been made regarding linting format or other coding standards. Please bring this up at the team meeting on Tuesday, May 23rd. |
Contributor
|
Details for our upcoming meeting, where we can discuss this, can be found on our calendar: https://lists.openmainframeproject.org/g/software-discovery-tool-discussion/calendar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Creating an initial draft for the flake8 integration in Software Discovery Tool
TODO:
Please take a look @pleia2 @arshPratap